Closed Bug 998874 Opened 5 years ago Closed 5 years ago

[marionette-apps] Update dependency of marionette-js-client to peer dependency 1.0.0

Categories

(Testing Graveyard :: JSMarionette, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rudyl, Assigned: rudyl)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #997045 +++

When working on Bug #997045, I found that I could not get the travis to pass the tests for marionette-apps, when I update the dependency of marionette-js-client to 1.1.6.

So, I fall back to trying to update the dependency to 1.1.5 and encountered a similar issue here.
Please refer to the travis job,
https://travis-ci.org/mozilla-b2g/marionette-apps/builds/23410030
This patch is to increase the timeout in waitForApp test, and seems it could work for travis to pass.

Evan, Gareth,

Do you think this is good to merge?
Thanks.
Attachment #8409568 - Flags: review?(gaye)
Attachment #8409568 - Flags: feedback?(evanxd)
Assignee: nobody → rlu
Status: NEW → ASSIGNED
Hi Rudy,
Nice work.
Just investigating the timeout change.
Thanks.
I think marionette-client should really be made into a "peer dependency"
Otherwise this works for me.
Comment on attachment 8409568 [details] [review]
Patch V1 - pull request 26

Patch updated to use peer dependency as suggested.
Evan, could you review this?

Thanks.
Attachment #8409568 - Flags: feedback?(evanxd) → review?(evanxd)
Depends on: 1000681
Attachment #8409568 - Flags: review?(evanxd) → review+
For the timeout issue, we should fix that at Bug 1000681.
Attachment #8409568 - Flags: review?(gaye)
Hi Rudy,
I think we should update dependency of marionette-js-client to 1.1.7 with `"marionette-client": "1.1.7"`. Please refer to https://github.com/mozilla-b2g/marionette-apps/pull/26/files#r11937058.
At the end, I think we should not update the dependency to 1.1.5 since it does not require that.
So, just modify this to peer dependency and keep it as 1.0.0.
Update the bug title as well.
Summary: [marionette-apps] Update dependency of marionette-js-client to 1.1.5 → [marionette-apps] Update dependency of marionette-js-client to peer dependency 1.0.0
Landed,
https://github.com/mozilla-b2g/marionette-apps/commit/12e79a9c4fb862aef34350400240433d3c4269ec

Thanks for the feedback and review.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.