Closed Bug 998896 Opened 10 years ago Closed 10 years ago

investigate the failure of HTML5Player of gaiatest

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: askeing, Assigned: zcampbell)

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
askeing
: review+
Bebe
: review+
Details | Review
When running the test_browser_play_youtube_video.py of gaiatest, the player.pause() doesn't work.
It will set the time to the middle of time-bar.
The player is working fine but as Askeing suggests player.pause() is failing.

We can't actually tap on the correct HTML5 controls which are deep down in Gecko and unreachable by Marionette. We can only tap on the screen where we think the controls are. 

Previously this worked but now it is tapping on the progress bar and causing the video to skip forwards instead of pausing.
I'm not sure what is the best solution just yet, thinking about it...
Dave I know you worked at this test. Maybe you could take a look...
Flags: needinfo?(dave.hunt)
This failed on today’s build:

Gaia      f0463704888881b8ed1619e8d4b0d851b0e0311b
Gecko     https://hg.mozilla.org/mozilla-central/rev/1d0496e30feb
BuildID   20140422040203
Version   31.0a1
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013


Stack trace:

Traceback (most recent call last):
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui/.env/local/lib/python2.7/site-packages/marionette_client-0.7.6-py2.7.egg/marionette/marionette_test.py", line 163, in run
testMethod()
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui/tests/python/gaia-ui-tests/gaiatest/tests/functional/browser/test_browser_play_youtube_video.py", line 48, in test_play_youtube_video
player.pause()
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui/tests/python/gaia-ui-tests/gaiatest/apps/browser/regions/html5_player.py", line 60, in pause
self.wait_for_condition(lambda m: self.is_paused)
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 54, in wait_for_condition
Wait(self.marionette, timeout).until(method, message=message)
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui/.env/local/lib/python2.7/site-packages/marionette_client-0.7.6-py2.7.egg/marionette/wait.py", line 143, in until
cause=last_exc)
TimeoutException: TimeoutException: Timed out after 30.0 seconds


We can't manually reproduce the issue.
I could replicate it.

I'll take the issue.
Assignee: nobody → zcampbell
Flags: needinfo?(dave.hunt)
Attached file github pr
Attachment #8410355 - Flags: review?(fyen)
Attachment #8410355 - Flags: review?(florin.strugariu)
Attachment #8410355 - Flags: review?(fyen) → review+
Comment on attachment 8410355 [details] [review]
github pr

Woks as expected
Attachment #8410355 - Flags: review?(florin.strugariu) → review+
https://github.com/mozilla-b2g/gaia/commit/6f495188860bbe4f857a88b078fc6a04086226bf
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: