999193 - Clean up bootstrap mozL10n API use in Email

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Email currently works around the bug in mozL10n.ready. 

This should be fixed https://github.com/mozilla-b2g/gaia/blob/master/apps/email/js/l10n.js#L7-L13 once we fix bug 993188.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: pull request

I moved away from using mozL10n.ready because the code does not benefit from the callack being fired on language change.

It overall seems that the whole app does not carry retranslation of strings provided by JS code. Not sure if it's a bug, but it's a separate issue.

Comment 2

[James Burke [:jrburke]]

Comment on attachment 8416827 [details] [review]
pull request

Tested on device and confirmed marionette tests still pass locally. Thanks!

Comment 3

[James Burke [:jrburke]]

To clarify a bit more:

The once makes sense here because we are setting a module export value, which only registered once anyway.

I tested switching the language and it works for for the displayed cards and any new cards, but if a card template was already loaded, it is not getting translated. I filed bug 1005760 to track that fix.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Patch: https://github.com/mozilla-b2g/gaia/commit/906fcc826e052b9c58743da18fc4a9c10cad08dc
Merge: https://github.com/mozilla-b2g/gaia/commit/91477e77b834b02770de3f2feddd4fab839a8cf4