Closed Bug 999236 Opened 6 years ago Closed 6 years ago

"TypeError: aCallback is null" when clicking link in the web console

Categories

(DevTools :: Console, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 33

People

(Reporter: harth, Assigned: sjakthol)

Details

Attachments

(1 file)

STR:

1) visit any page
2) open web console
3) eval `window`
4) click the link that appears

ERROR resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/webconsole/webconsole.js:2712 - TypeError: aCallback is null
Note, this means that clicking the link does nothing. Also happens for evaling 'document'.

I don't have time to look at it fully, but it seems to have something to do with it being a JSObject and not a ObjectWithURL in console.js.
Here's a patch that ensures all JSObjects that render anchors with URLs use the default handler if nothing else is specified. 

Ran the webconsole tests locally and this patch didn't cause any new failures.
Attachment #8415952 - Flags: review?(mihai.sucan)
Attachment #8415952 - Flags: review?(mihai.sucan) → review?(rcampbell)
patch works as advertised.

I'd like to get a try run for this. Do you have Try access, Sami?

https://wiki.mozilla.org/ReleaseEngineering/TryServer
Status: NEW → ASSIGNED
Attachment #8415952 - Flags: review?(rcampbell) → review+
No, I don't have access to the Try servers.
Flagging Rob to do a try push.
Flags: needinfo?(rcampbell)
Got my access, here's a try run: https://tbpl.mozilla.org/?tree=Try&rev=8889a7500f25
Flags: needinfo?(rcampbell)
Assignee: nobody → sjakthol
Try run succeeded mostly: one unrelated test failure (bug 1028609) and a weird build error fixed by retry.
Thanks for the patch!

https://hg.mozilla.org/integration/fx-team/rev/24d194587ab5
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Thanks Sami! Nice work.
https://hg.mozilla.org/mozilla-central/rev/24d194587ab5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.