999236 - "TypeError: aCallback is null" when clicking link in the web console

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Heather Arthur [:harth]]

STR:

1) visit any page
2) open web console
3) eval `window`
4) click the link that appears

ERROR resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/webconsole/webconsole.js:2712 - TypeError: aCallback is null

Comment 1

[Heather Arthur [:harth]]

Note, this means that clicking the link does nothing. Also happens for evaling 'document'.

I don't have time to look at it fully, but it seems to have something to do with it being a JSObject and not a ObjectWithURL in console.js.

Comment 2

[Sami Jaktholm]

Attachment: webconsole-open-links-without-callback-in-new-tab.patch

Here's a patch that ensures all JSObjects that render anchors with URLs use the default handler if nothing else is specified. 

Ran the webconsole tests locally and this patch didn't cause any new failures.

Comment 3

[Rob Campbell [:rc] (:robcee)]

patch works as advertised.

I'd like to get a try run for this. Do you have Try access, Sami?

https://wiki.mozilla.org/ReleaseEngineering/TryServer

Comment 4

[Sami Jaktholm]

No, I don't have access to the Try servers.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Flagging Rob to do a try push.

Comment 6

[Sami Jaktholm]

Got my access, here's a try run: https://tbpl.mozilla.org/?tree=Try&rev=8889a7500f25

Comment 7

[Sami Jaktholm]

Try run succeeded mostly: one unrelated test failure (bug 1028609) and a weird build error fixed by retry.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Thanks for the patch!

https://hg.mozilla.org/integration/fx-team/rev/24d194587ab5

Comment 9

[Rob Campbell [:rc] (:robcee)]

Thanks Sami! Nice work.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/24d194587ab5