Closed
Bug 999350
Opened 10 years ago
Closed 10 years ago
[AudioChannel] System app will receive "none" not one of audio channel types when playing audio in first time.
Categories
(Firefox OS Graveyard :: AudioChannel, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S1 (9may)
People
(Reporter: mchen, Assigned: mchen)
References
Details
Attachments
(1 file, 1 obsolete file)
13.14 KB,
patch
|
mchen
:
review+
|
Details | Diff | Splinter Review |
When an app tries to play audio with normal type, the system app may get two possible results from mozChromeEvent - "audio-channel-changed". A. Receive "none" first then "normal". B. Directly receive "normal". The result A will be happened when playing first audio after system boot up. After that, only result B will be received. This will effect audio channel related testcases because we don't this test case will run on result A or B. So we need to fix it.
Assignee | ||
Comment 1•10 years ago
|
||
The root cause is that a. initial values of AudioChannelService::mCurrentHigherChannel and mCurrentVisibleHigherChannel are INT32_MAX. b. the value indicates no audio channels there is -1. c. so the first current value will be different then -1 then "none" is fired. The patch contains a. To change initial values of AudioChannelService::mCurrentHigherChannel and mCurrentVisibleHigherChannel to -1 not INT32_MAX. b. Add test case for mozChromeEvent - audio-channel-change/visible-audio-channel-change. And the rough idea is b1. Use SystemProxy.jsm to relay mozChromeEvent from parent to child process. (because mochitest run on emulator is on child process). b2. file_audio.html is another OOP process which is responsible for playing each types then stopping them one by one. b3. test_audioChannelChange.html tried to launch file_audio.html and control it's visible status so we can verify audio playing in the foreground or background or both.
Assignee: nobody → mchen
Attachment #8410141 -
Flags: review?(amarchesini)
Assignee | ||
Comment 2•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=409fea045d9a
Updated•10 years ago
|
Attachment #8410141 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Carry reviewer name.
Attachment #8410141 -
Attachment is obsolete: true
Attachment #8412491 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Flags: in-testsuite+
Keywords: checkin-needed
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/d3aaf927afb8
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d3aaf927afb8
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S1 (9may)
You need to log in
before you can comment on or make changes to this bug.
Description
•