Closed Bug 999365 Opened 10 years ago Closed 10 years ago

Stretch new tabs toolbarbutton instead of centring it

Categories

(SeaMonkey :: MailNews: General, defect)

Product:
SeaMonkey
Component:
MailNews: General
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(seamonkey2.26 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.28
Tracking Flags:
Tracking Status
seamonkey2.26 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

Details

Attachments

(2 files, 2 obsolete files)

patch v3
1.17 KB, patch
neil
: review+
Details | Diff | Splinter Review
missingnewtabbutton.png
146.09 KB, image/png
Details 
Certain themes (like FF3 theme for SeaMonkey) don't properly display the "new tab" toolbar button in the mailnews component of SeaMonkey because the toolbarbutton is centred, not stretched.  As far as I can tell there is no good reason for this.  The one-liner fix for this is to change "center" to "stretch" on this line:
http://mxr.mozilla.org/comm-central/source/suite/mailnews/tabmail.xml#995
Attached patch patch v1 (obsolete) — — Splinter Review 
Adding patch to fix problem.
Attachment #8410200 - Flags: review?(neil)
(Note that "stretch" is the default value for align.)

Do we even need the box there at all?
Maybe not but I was trying to change as little as possible to minimize the potential for breakage.
Comment on attachment 8410200 [details] [diff] [review]
patch v1

OK, r=me if you remove the align completely. (This then allows themes to restore the align using -moz-box-align if they need it.)
Attachment #8410200 - Flags: review?(neil) → review+
Attached patch patch v2 (obsolete) — — Splinter Review 
Removes the align completely.
Attachment #8410200 - Attachment is obsolete: true
Attachment #8410608 - Flags: review?(neil)
Attachment #8410608 - Flags: review?(neil) → review+
Keywords: checkin-needed
Attached patch patch v3 — — Splinter Review 
Oops, just realized that patch was based off a modified version of the source on my local machine.  This one is the proper one.
Attachment #8410608 - Attachment is obsolete: true
Attachment #8410631 - Flags: review?(neil)
If you post a new patch for review you should remove the checkin-needed request for the obsoleted one.
Keywords: checkin-needed
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #8410631 - Flags: review?(neil) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/711cff832014
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.28
Blocks: 1018792
landed on comm-release in prep for SeaMonkey 2.26.1

$ hg tip
changeset:   20187:ba5a407b0217
branch:      SEA_2_26_1_RELBRANCH
tag:         tip
user:        Jeremy Morton <bugzilla@game-point.net>
date:        Wed Apr 23 00:27:38 2014 +0100
summary:     Bug 999365 - Remove centering of mailnews new tab button so as to stretch it (default behaviour). r=Neil, a=me
status-seamonkey2.26: --- → fixed
Attached image missingnewtabbutton.png — 
Please reopen this bug report. New tab button is missing in SeaMonkey linux versions 2.26.1, 2.29., 2.29.1, and 2.30 (beta). See attached screenshot from SeaMonkey 2.30 beta.
User agent: Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0 SeaMonkey/2.30
Build identifier: 20140926072750
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: