999407 - add --setenv option for mochitests run through mach

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Nathan Froyd [:froydnj]]

runtests.py supports this, and it's handy for setting up NSPR logging on only
the main browser process but not the xpcshell HTTP server process.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: add --setenv option for mochitests run through mach

We stuff the option's value into |environment| to keep it consistent with
MochitestOptions.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8410241 [details] [diff] [review]
add --setenv option for mochitests run through mach

Review of attachment 8410241 [details] [diff] [review]:
-----------------------------------------------------------------

at first I thought- don't we have this, then I realized it was for mach.  It is too bad mach cannot use mochitest_options.py.

Comment 3

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d232ce4ffb5

Comment 4

[Nathan Froyd [:froydnj]]

(In reply to Joel Maher (:jmaher) from comment #2)
> at first I thought- don't we have this, then I realized it was for mach.  It
> is too bad mach cannot use mochitest_options.py.

Well, mach_commands.py clearly can, because it instantiates MochitestOptions, and then fills in various bits and pieces for the moral equivalent of runtests.py.  So really, we should be able to use MochitestOptions to construct the command decorators that mach needs.  I will file a bug.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4d232ce4ffb5