999413 - clean useless files when execute make

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

follow-up bug of bug 998954 
https://bugzilla.mozilla.org/show_bug.cgi?id=998954#c13

we should make sure user has same files as github before execute |make|.

Comment 1

[Albert [:albert]]

Hi,

Working in bug 995900 I found that build_stage folders are not cleaned properly since bug 998954 landed. It seems that https://github.com/acperez/gaia/blob/master/Makefile#L528 is not working, the 'rm' command has no effect.

Comment 2

[Albert [:albert]]

You should remove double quote. Use

rm -rf $(STAGE_DIR)/$$APP/*;

instead of

rm -rf "$(STAGE_DIR)/$$APP/*";

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Thanks, Albert!

Hi Tim,
could you help me to review this patch?

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8413603 [details] [review]
PR to master

Normally you need double quote to make sure shell script work with path with space, but obviously that should be removed if it doesn't work at all.

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks Tim,
merge to master
https://github.com/mozilla-b2g/gaia/commit/3c00a8c4a775e124186e0d48ee624d4dc25b14e0