999463 - Remove hack which swallows keyboardchange events to prevent homescreen being resized

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Ben Francis [:benfrancis]]

rocketbar.js has a hack which swallows keyboardchange events when the Rocketbar is focused so that the homescreen doesn't get resized, I think because it looks ugly when the homescreen dock appears half way up the screen. Alive pointed out that this should be removed in his review of bug 993346.

Hopefully in homescreen 2.0 we won't need this because the homescreen app will cope better with being resized, but if we have Rocketbar with the current homescreen we need a solution.

I tried telling the layout manager not to send a resize event when AppWindowManager.getActiveApp().isHomescreen is true, but there are some places where the current homescreen *does* want to be resized (e.g. e.me search and collections).

Should we get the Rocketbar to fire rocketbarfocus and rocketbarblur events to tell the layout manager when to start and stop ignoring keyboardchange events?

I'm not sure what the right fix is for this going forward.

Comment 1

[Kevin Grandon :kgrandon]

This was mainly a performance issue, as resizing is quite intensive. You also don't want to resize any active app when you enter rocketbar I would think, so just checking for homescreen won't work.

I'm not sure if having the rocketbar firing events is any better, but may be worth a shit.

Comment 2

[Kevin Grandon :kgrandon]

Oh wow that was a bad typo. Sorry.

Comment 3

[Ben Francis [:benfrancis]]

Can we close this bug now?

Comment 4

[Kevin Grandon :kgrandon]

(In reply to Ben Francis [:benfrancis] from comment #3)
> Can we close this bug now?

We are sadly still using it. If we want something better then I guess we should keep this open.

Comment 5

[BMO Automation]

Firefox OS is not being worked on