999480 - Loop desktop Panel should use a router & templated views

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Loop Desktop panel still uses a single view for handling the different application states, while we recently introduced a shared routing system which could greatly help maintaining application state.

Also, we switched to using template based views everywhere while the panel main view still use a static DOM hierarchy; we should update the existing Panel code to use that new system.

Comment 1

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: https://github.com/adamroach/gecko-dev/pull/18

gecko-dev patch

Comment 2

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: https://github.com/mozilla/loop-client/pull/24

loop-client patch

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8410311 [details] [review]
https://github.com/adamroach/gecko-dev/pull/18

r=Standard8, please add r=Standard8 to the commit comment before landing.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8410312 [details] [review]
https://github.com/mozilla/loop-client/pull/24

r=Standard8, please add that to the commit comment before landing.

Comment 5

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Landed https://github.com/adamroach/gecko-dev/pull/18: https://github.com/adamroach/gecko-dev/commit/41c83b3121ab1222a8f58e4e28954467af9366b6

Comment 6

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Landed https://github.com/mozilla/loop-client/pull/24: https://github.com/mozilla/loop-client/commit/880e6aa49b15774921e959a25f06401d7aaa48d4

Comment 7

[Mark Banner (:standard8)]

https://hg.mozilla.org/projects/elm/rev/28491729837e
https://hg.mozilla.org/projects/elm/rev/1a6d884f153e

Comment 8

[Mark Banner (:standard8)]

https://hg.mozilla.org/mozilla-central/rev/28491729837e
https://hg.mozilla.org/mozilla-central/rev/1a6d884f153e

Comment 9

[u279076]

Does this need QA testing?

Comment 10

[Mark Banner (:standard8)]

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #9)
> Does this need QA testing?

Nothing specific, standard smoketests are fine.

Comment 11

[u279076]

Deprioritizing for QA based on comment 10. Please needinfo me to request QA.