999520 - Update keyboard app's dismiss method to work on v1.3 too

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Bob Silverberg [:bsilverberg]]

The dismiss method of the keyboard app is using Javascript that is incompatible with v1.3. This bug is to create a version that will work on v1.3 and above.

Comment 1

[Bob Silverberg [:bsilverberg]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18536

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8410377 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18536

I added a comment about potentially simplifying the code, but r=me with or without this change. I haven't run any tests though, but I'm guessing you have. :)

Comment 3

[Zac C (:zac)]

Comment on attachment 8410377 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18536

r+
I will hold off on the merge in event you want to tweak the syntax

Comment 4

[Bob Silverberg [:bsilverberg]]

I will update the PR this afternoon so it can be merged. Thanks for the reviews everyone!

Comment 5

[Bob Silverberg [:bsilverberg]]

The PR has been updated. This is ready to merge.

Comment 6

[Zac C (:zac)]

I was about to merge but now the indentation looks quite busted :/

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Zac C (:zac) from comment #6)
> I was about to merge but now the indentation looks quite busted :/

See the PR comments. This is a multi-line string, which means it preserves white-space. For the indentation to be correct as JavaScript it is reset to column 0.

Comment 8

[Zac C (:zac)]

OK I did not know that, thanks!

Merged:
https://github.com/mozilla-b2g/gaia/commit/5e55e256dbabab5b9d7fadf18ea80e89695d9f94