Closed Bug 999605 Opened 10 years ago Closed 10 years ago

Intermittent system/test/unit/hardware_buttons_test.js | system/HardwareButtons hold sleep and press home (screen disabled) | expected false to be true

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 affected, b2g-v2.1 fixed)

Status:
RESOLVED FIXED
Milestone:
2.1 S2 (15aug)
Tracking Flags:
Tracking Status
b2g-v2.0 --- affected
b2g-v2.1 --- fixed

People

(Reporter: RyanVM, Assigned: timdream)

Details

(Keywords: intermittent-failure, Whiteboard: [FT:System-Platform])

Attachments

(1 file)

mozilla-b2g:master PR#22704
46 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=38260421&tree=B2g-Inbound

b2g_ubuntu64_vm b2g-inbound opt test gaia-unit on 2014-04-22 10:00:54 PDT for push dd9f506e6a88
slave: tst-linux64-spot-245

10:22:54     INFO -  gaia-unit-tests TEST-START | system/test/unit/hardware_buttons_test.js |
10:22:54     INFO -  gaia-unit-tests TEST-START | system/test/unit/hardware_buttons_test.js | system/HardwareButtons
10:22:54     INFO -  gaia-unit-tests TEST-PASS  | system/test/unit/hardware_buttons_test.js | system/HardwareButtons press and release home (screen enabled)
10:22:55     INFO -  gaia-unit-tests TEST-PASS  | system/test/unit/hardware_buttons_test.js | system/HardwareButtons press and release home (screen disabled)
10:22:55     INFO -  gaia-unit-tests TEST-PASS  | system/test/unit/hardware_buttons_test.js | system/HardwareButtons press and release sleep (screen enabled)
10:22:55     INFO -  gaia-unit-tests TEST-PASS  | system/test/unit/hardware_buttons_test.js | system/HardwareButtons press and release sleep (screen disabled)
10:22:55     INFO -  gaia-unit-tests TEST-PASS  | system/test/unit/hardware_buttons_test.js | system/HardwareButtons hold home and press sleep (screen enabled)
10:22:55     INFO -  gaia-unit-tests TEST-PASS  | system/test/unit/hardware_buttons_test.js | system/HardwareButtons hold home and press sleep (screen disabled)
10:22:55     INFO -  gaia-unit-tests TEST-PASS  | system/test/unit/hardware_buttons_test.js | system/HardwareButtons hold sleep and press home (screen enabled)
10:22:55     INFO -  gaia-unit-tests TEST-UNEXPECTED-FAIL | system/test/unit/hardware_buttons_test.js | system/HardwareButtons hold sleep and press home (screen disabled) | expected false to be true
10:22:55     INFO -  gaia-unit-tests INFO       | stack trace:
10:22:55     INFO -      Error: expected false to be true
10:22:55     INFO -          at chaiAssert (http://system.gaiamobile.org:8080/common/test/helper.js:33:1)
10:22:55     INFO -          at get (http://system.gaiamobile.org:8080/common/vendor/chai/chai.js:374:1)
10:22:55     INFO -          at isTrue (http://system.gaiamobile.org:8080/common/vendor/chai/chai.js:1367:5)
10:22:55     INFO -          at (anonymous) (http://system.gaiamobile.org:8080/test/unit/hardware_buttons_test.js:234:5)
10:22:55     INFO -          at wrapper (http://system.gaiamobile.org:8080/common/test/mocha_generators.js:62:13)
10:22:55     INFO -          at run (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)
10:22:55     INFO -          at runTest (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081:5)
10:22:55     INFO -          at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127:7)
10:22:55     INFO -          at next (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007:7)
10:22:55     INFO -          at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016:7)
10:22:55     INFO -          at next (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964:16)
10:22:55     INFO -          at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3979:7)
10:22:55     INFO -          at done (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3700:5)
10:22:55     INFO -          at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3712:9)
10:22:55     INFO -          at (anonymous) (http://system.gaiamobile.org:8080/common/test/mocha_generators.js:46:13)
10:22:55     INFO -          at wrapper (http://system.gaiamobile.org:8080/common/test/mocha_generators.js:73:15)
10:22:55     INFO -          at run (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)
10:22:55     INFO -          at next (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973:5)
10:22:55     INFO -          at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3979:7)
10:22:55     INFO -          at done (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3700:5)
10:22:55     INFO -          at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3712:9)
10:22:55     INFO -          at (anonymous) (http://system.gaiamobile.org:8080/common/test/mocha_generators.js:46:13)
10:22:55     INFO -          at wrapper (http://system.gaiamobile.org:8080/common/test/mocha_generators.js:73:15)
10:22:55     INFO -          at run (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)
10:22:55     INFO -          at next (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973:5)
10:22:55     INFO -          at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984:5)
10:22:55     INFO -          at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932:28)
Tim, any idea what might be going wrong in this test? :)
status-b2g-v2.0: --- → affected
status-b2g-v2.1: --- → affected
Flags: needinfo?(timdream)
Let me try what I can do.
Assignee: nobody → timdream
Status: NEW → ASSIGNED
Flags: needinfo?(timdream)
Whiteboard: [FT:System-Platform]
Target Milestone: --- → 2.1 S2 (15aug)
The test is pretty deterministic, the only part I can see "random" is the random for returning value of stub'd setTimeout() function. I am replacing that with an ++i and see if that make any difference.
Comment on attachment 8470573 [details] [review]
mozilla-b2g:master PR#22704

Kevin, Does this look good to you?
Attachment #8470573 - Flags: review?(kgrandon)
Comment on attachment 8470573 [details] [review]
mozilla-b2g:master PR#22704

Sure, seems like a better way of doing things to me. Also based on your run it seems to have solved this intermittent. Nice work!
Attachment #8470573 - Flags: review?(kgrandon) → review+
Let's see...

master: https://github.com/mozilla-b2g/gaia/commit/321ffc195a7cabf74d740e231c5f9cdc44e8906e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-v2.1: affected → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: