Closed
Bug 999618
Opened 10 years ago
Closed 10 years ago
fix browser-chrome tests in browser/base/content/test/general to not remove the original tab
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: froydnj, Unassigned)
Details
Attachments
(1 file)
6.52 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•10 years ago
|
||
These fixes do not fix all the busted tests in this directory; they only fix the tests that are easy enough to modify with a few lines. The other ones really do seem to rely on removing all the tabs from a window, and will need a little bit more care in rewriting.
Reporter | ||
Comment 2•10 years ago
|
||
Comment on attachment 8410464 [details] [diff] [review] fix browser-chrome tests in browser/base/content/test/general to not remove the original tab I was wondering why Ehsan wasn't reviewing this patch...
Attachment #8410464 -
Flags: review?(ehsan)
Comment 3•10 years ago
|
||
Sorry, my psychic abilities are deteriorating. ;-)
Comment 4•10 years ago
|
||
Comment on attachment 8410464 [details] [diff] [review] fix browser-chrome tests in browser/base/content/test/general to not remove the original tab Review of attachment 8410464 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/test/general/browser_bug406216.js @@ +29,5 @@ > executeSoon(doTabsTest); > }, true); > } > > function doTabsTest() { This test is really stupid, essentially it's testing whether gBrowser.removeTab works! Perhaps we should remove it altogether. Follow-up?
Attachment #8410464 -
Flags: review?(ehsan) → review+
Comment 5•10 years ago
|
||
Can you please send an email to firefox-dev asking reviewers and developers to pay attention to this anti-pattern? Thanks!
Reporter | ||
Comment 6•10 years ago
|
||
(In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #5) > Can you please send an email to firefox-dev asking reviewers and developers > to pay attention to this anti-pattern? Thanks! Which anti-pattern are you referring to? Just loading URLs into existing tabs, rather than new ones?
Comment 7•10 years ago
|
||
Tests replacing the original tab (such as bug 999604 too)
Comment 8•10 years ago
|
||
Backed out for test failures: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&jobname=r-chr&rev=16a37bafa5c8 https://hg.mozilla.org/integration/mozilla-inbound/rev/787663bcaf04
Comment 9•10 years ago
|
||
Please see bug 805068 comment 7...
Comment 10•10 years ago
|
||
These tests don't need to change. I'm addressing the underlying issue in bug 805068.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•