999619 - Disabling contenteditable while focussed breaks badly

Status: UNCONFIRMED

(Core :: DOM: Editor, defect)

Description

[ejsanders]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20140410211200

Steps to reproduce:

See http://jsfiddle.net/C98wg/


Actual results:

CE after disable still has focus state, cursor and keydown events, but is not actually editable


Expected results:

Setting ce=false should blur the box, remove the cursor and stop emitting keydown events.

Comment 1

[Sorin Davidoi]

Attachment: fix(dom/base/Element): Clear focus when the active element is hidden

This fixes a failing Web Platform Test (https://github.com/w3c/web-platform-tests/blob/009111410a1099e85d4027a679985975757ceb4d/html/editing/focus/processing-model/focus-fixup-rule-one-no-dialogs.html#L36). Wasn't sure where exactly to place this logic - it makes sense to me to be done before the attribute changed callback is called.

Review commit: https://reviewboard.mozilla.org/r/219252/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219252/

Comment 2

[Sorin Davidoi]

Attachment: fix(dom/html/nsGenericHTMLElement): Clear focused when the active element is disabled

Fixes there failing Web Platform Tests:
 - https://github.com/w3c/web-platform-tests/blob/009111410a1099e85d4027a679985975757ceb4d/html/editing/focus/processing-model/focus-fixup-rule-one-no-dialogs.html#L24
 - https://github.com/w3c/web-platform-tests/blob/009111410a1099e85d4027a679985975757ceb4d/html/editing/focus/processing-model/focus-fixup-rule-one-no-dialogs.html#L62
 - https://github.com/w3c/web-platform-tests/blob/009111410a1099e85d4027a679985975757ceb4d/html/editing/focus/processing-model/focus-fixup-rule-one-no-dialogs.html#L74

Review commit: https://reviewboard.mozilla.org/r/219254/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219254/

Comment 3

[Sorin Davidoi]

Attachment: fix(dom/html/nsGenericHTMLElement): Clear focus when a contentEditable is disabled on the active element

Fixes a failing Web Platform Test (https://github.com/w3c/web-platform-tests/blob/009111410a1099e85d4027a679985975757ceb4d/html/editing/focus/processing-model/focus-fixup-rule-one-no-dialogs.html#L99).

Review commit: https://reviewboard.mozilla.org/r/219256/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219256/

Comment 4

[Sorin Davidoi]

Attachment: fix(dom/base/Element): Clear focus when tabIndex is unset from the active element

Fixes a failing Web Platform Test (https://github.com/w3c/web-platform-tests/blob/009111410a1099e85d4027a679985975757ceb4d/html/editing/focus/processing-model/focus-fixup-rule-one-no-dialogs.html#L86).

Review commit: https://reviewboard.mozilla.org/r/219258/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219258/

Comment 5

[Sorin Davidoi]

Attachment: refactor(dom/base/Element): Use Blur() when the element is hidden

Review commit: https://reviewboard.mozilla.org/r/219260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219260/

Comment 6

[Sorin Davidoi]

Attachment: refactor(dom/base/Element): Use Blur() when the tabIndex is removed

Review commit: https://reviewboard.mozilla.org/r/219262/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219262/

Comment 7

[Sorin Davidoi]

Attachment: refactor(dom/html/nsGenericHTMLElement): Use Blur() when the element is disabled

Review commit: https://reviewboard.mozilla.org/r/219264/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219264/