999676 - [System] Remove un-needed homescreen visibility setting

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kevin Grandon :kgrandon]

There appears to be a call to getHomescreen.setVisible(false) here: https://github.com/mozilla-b2g/gaia/blob/d8904c5af6152f5d647a93a0c31227171ddecd87/apps/system/js/app_window_manager.js#L99

I've been trying to track down history, but haven't found much as to why it was added, nor are there unit/integration tests testing this. I tested this on b2g desktop and on a device and it seems like it should be save to remove this.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Alive - are you ok with removing this?

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8410522 [details] [review]
Github pull request

Thank you Kevin, I am fixing this in https://bugzilla.mozilla.org/show_bug.cgi?id=985037

Comment 3

[Diego Wilson [:diego]]

This is blocking bug 980549 which is 1.4+

Comment 4

[Kevin Grandon :kgrandon]

(In reply to Alive Kuo [:alive][NEEDINFO!][God bless Taiwan.] from comment #2)
> Comment on attachment 8410522 [details] [review]
> Github pull request
> 
> Thank you Kevin, I am fixing this in
> https://bugzilla.mozilla.org/show_bug.cgi?id=985037

Ok, I didn't see the two commits conflicting so I've gone ahead and landed based on your R+. I am concerned that my other patch will conflict with that one though, so I've left a comment in the bug. I'll sync up with you in your morning. Thanks!

https://github.com/mozilla-b2g/gaia/commit/a11657b64fa36f2c7e0e815d0d034ca9fee7e1bf

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Need rebasing for v1.4 uplift.

Comment 6

[Kevin Grandon :kgrandon]

Please 1.4- this one, I think this doesn't impact the edge case in bug 980549 after all, and we will solve it in the other blocking bugs.