Closed Bug 999753 Opened 7 years ago Closed 7 years ago

Add support for starting B2G desktop build with -oop

Categories

(Testing Graveyard :: JSMarionette, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S4 (20june)

People

(Reporter: jgriffin, Assigned: evanxd)

References

Details

(Whiteboard: [p=5])

Attachments

(3 files)

In bug 998500, qdot is adding a -oop argument to the B2G desktop build, that causes it to run in OOP-mode.  We want to schedule tests against this mode in buildbot, but to do that, we need a way for node-based tests to launch the build using -oop.

Gareth, Julien, Michael, do one of you have time to add support for this?
Hi Jonathan,
I could help this.
Assignee: nobody → evanxd
If you think it's useful for unit tests as well, please file another bug and I can add it to bin/gaia-test.
Thanks Evan!

(In reply to Julien Wajsberg [:julienw] from comment #2)
> If you think it's useful for unit tests as well, please file another bug and
> I can add it to bin/gaia-test.

In TBPL, we use a Python runner for the unit tests, and that's already been updated.  If we move to the JS runner that's used by Travis, we'll need it in bin/gaia-test as well.
Blocks: 1001029
Hi Evan, have you had a chance to look at this?
Hi Armen,
Really sorry, I'm busy on other blocking bugs.
Feel free to steal this bug.
Assignee: evanxd → nobody
Hi Evan,
Anyone else that you know could help with this? Or who can help me find someone?

If not, when do you think the earliest could be to look into it?

I wish I had the knowledge to steal it :)
See comment 6.
Flags: needinfo?(evanxd)
Hi Armen,

Sure, I think I could do this in next week.

Sorry for the late response.
Flags: needinfo?(evanxd)
Assignee: nobody → evanxd
Target Milestone: --- → 1.5 S2 (23may)
Status ping; do you still think you'll be able to get to this this week Evan?
Flags: needinfo?(evanxd)
Hi Jonathan,

Sorry, again.
I'm working on Bug 1003795.
It is an urgent issue.

Could we start to fix this bug at 5/26(next Monday in CST)?
Flags: needinfo?(evanxd)
Yes, I think that's fine.  Thanks Evan.
Target Milestone: 2.0 S2 (23may) → 2.0 S3 (6june)
Hi Jonathan,

We could use the `dom.ipc.browser_frames.oop_by_default` preference to enable OOP mode, right? I see it at [1].

We could add the preference into the profile[2] used by the js marionette framework. So it means that js marionette already supports to start B2G desktop in OOP mode.

[1] https://bugzilla-dev.allizom.org/show_bug.cgi?id=923961#c11
[2] https://github.com/mozilla-b2g/gaia/blob/master/shared/test/integration/profile.js
Flags: needinfo?(jgriffin)
Status: NEW → ASSIGNED
We could just add the preference into the profile to enable the oop mode.
It looks like you need to set a whole bunch of prefs, not just one.  See the patch in bug https://bugzilla.mozilla.org/show_bug.cgi?id=998500.

How can we tell the integration tests to do this when we invoke 'make test-integration'?
Flags: needinfo?(jgriffin)
So we would like to have something like `make test-integration OOP=1` to enable the oop mode for b2g desktop, right?
Yes, that would be great!
Hi Gregor,

Could we just the `dom.ipc.browser_frames.oop_by_default` preference as `true` to enable OOP mode for b2g desktop? Or we just need to run b2g desktop with the -oop argument?

I found out the preference in your comment[1].
Thanks.

[1] https://bugzilla-dev.allizom.org/show_bug.cgi?id=923961#c11
Flags: needinfo?(anygregor)
Could we just the `dom.ipc.browser_frames.oop_by_default` preference as `true` to enable OOP mode for b2g desktop?
->
Could we set the `dom.ipc.browser_frames.oop_by_default` preference as `true` to enable OOP mode for b2g desktop?
(In reply to Evan Tseng [:evanxd][:愛聞插低] from comment #18)
> Could we just the `dom.ipc.browser_frames.oop_by_default` preference as
> `true` to enable OOP mode for b2g desktop?
> ->
> Could we set the `dom.ipc.browser_frames.oop_by_default` preference as
> `true` to enable OOP mode for b2g desktop?

See https://groups.google.com/forum/#!topic/mozilla.dev.b2g/8lnl2-sFOJM
There are more flags that need to be toggled these days. You should just start b2g-desktop with the oop command line flag
Flags: needinfo?(anygregor)
Hi James,

Could you help to review the patch?

Thanks.
Attachment #8437454 - Flags: review?(jlal)
Hi James,

Could you help me to review the patch?

Thanks.
Attachment #8437455 - Flags: review?(jlal)
Attached file Patch for gaia
Hi James,

Could you help to review the patch?

Thanks.
Attachment #8437456 - Flags: review?(jlal)
Got it.
Thanks, Gregor.
Comment on attachment 8437455 [details] [review]
Patch for marionette-js-runner

Provisional R+ given that you add some docs somewhere for this... I think we need to figure out a better way to handle these cases (passing the flags to a host)
Attachment #8437455 - Flags: review?(jlal) → review+
Hi James,

And how about the patches for gaia[1] and mozilla-runner[2]? Do you mean that all these patches also get r+?

[1] https://bugzilla.mozilla.org/attachment.cgi?id=8437456
[2] https://bugzilla.mozilla.org/attachment.cgi?id=8437454
Flags: needinfo?(jlal)
Comment on attachment 8437454 [details] [review]
Patch for mozilla-runner

Question in the bug here if you remove the === -> === r+
Attachment #8437454 - Flags: review?(jlal)
Flags: needinfo?(jlal)
Comment on attachment 8437456 [details] [review]
Patch for gaia

r+ we need to spend some energy cleaning up ./bin/gaia-marionette so it is not using both flags and environment variables but I won't complain about this now [too much]
Attachment #8437456 - Flags: review?(jlal) → review+
Comment on attachment 8437454 [details] [review]
Patch for mozilla-runner

Sorry, just a mistake. Let's keep `==` there.
Attachment #8437454 - Flags: review?(jlal)
Attachment #8437454 - Flags: review?(jlal) → review+
Hi James,

Excuse me.
Could you add me into the owner list of mozilla-runner? Then I could publish the changes.

Thanks.
Flags: needinfo?(jlal)
Done and pushed.
Flags: needinfo?(jlal)
Hi Jonathan,

JSMarionette in Gaia supports OOP mode currently. We could just run `make test-integration OOP=1`[1] to run test in OOP mode.

[1] https://github.com/mozilla-b2g/gaia#running-tests-in-oop-mode
Whiteboard: [p=5]
Target Milestone: 2.0 S3 (6june) → 2.0 S4 (20june)
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
master: da58535b7acc84b1b6686183f95ecdda48ef6543
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.