Closed
Bug 999884
Opened 10 years ago
Closed 10 years ago
Make DBusReplyHandler not use mozilla::RefCounted; r=smaug
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
1.43 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8410725 -
Flags: review?(bugs)
Comment 2•10 years ago
|
||
Comment on attachment 8410725 [details] [diff] [review] Make DBusReplyHandler not use mozilla::RefCounted; r=smaug >+ virtual ~DBusReplyHandler() { { goes to the next line
Attachment #8410725 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c81b25ae61c0
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c81b25ae61c0
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Comment 5•10 years ago
|
||
This caused bug 1000961, which is an OS restart crash anytime Bluetooth is turned on. This is also a smoketest blocker. Can you backout?
Flags: needinfo?(ehsan)
Flags: needinfo?(bugs)
Comment 6•10 years ago
|
||
As far as I see, this bug just revealed rather bad issue in DBusReplyHandler, which much be fixed. There is a patch in bug 1000961.
Flags: needinfo?(bugs)
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Jason Smith [:jsmith] from comment #5) > This caused bug 1000961, which is an OS restart crash anytime Bluetooth is > turned on. This is also a smoketest blocker. > > Can you backout? Yes, the right fix here is not backing this out. We should just fix bug 1000961.
Flags: needinfo?(ehsan)
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•