Make DBusReplyHandler not use mozilla::RefCounted; r=smaug

RESOLVED FIXED in mozilla31

Status

()

defect
RESOLVED FIXED
5 years ago
5 months ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla31
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

No description provided.
Assignee: nobody → ehsan
Blocks: 991812
Attachment #8410725 - Flags: review?(bugs)
Comment on attachment 8410725 [details] [diff] [review]
Make DBusReplyHandler not use mozilla::RefCounted; r=smaug

>+  virtual ~DBusReplyHandler() {
{ goes to the next line
Attachment #8410725 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/c81b25ae61c0
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Depends on: 1000961
This caused bug 1000961, which is an OS restart crash anytime Bluetooth is turned on. This is also a smoketest blocker.

Can you backout?
Flags: needinfo?(ehsan)
Flags: needinfo?(bugs)
No longer depends on: 1000961
As far as I see, this bug just revealed rather bad issue in DBusReplyHandler, which much be fixed.
There is a patch in bug 1000961.
Flags: needinfo?(bugs)
(In reply to Jason Smith [:jsmith] from comment #5)
> This caused bug 1000961, which is an OS restart crash anytime Bluetooth is
> turned on. This is also a smoketest blocker.
> 
> Can you backout?

Yes, the right fix here is not backing this out.  We should just fix bug 1000961.
Flags: needinfo?(ehsan)
Depends on: 1000961
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.