1030826 - (winasan) Support AddressSanitizer builds on Windows with clang-cl

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[(no longer active)]

With the work done in bug 752004, we should be ready to try this out!

Comment 1

[Ting-Yu Chou [:ting] (away)]

dmajor, are you still working on this? I am picking up what else need to be fixed here, were you able to run mochitest with ASan?

Comment 2

[(Away)]

(In reply to Ting-Yu Chou [:ting] from comment #1)
> dmajor, are you still working on this? I am picking up what else need to be
> fixed here, were you able to run mochitest with ASan?

I haven't looked at this in a while. A couple of months ago, ASan builds were good enough that I could launch the browser and watch youtube locally. I deliberately didn't investigate mochitests because historically Windows ASan builds were so finicky that no two developers got the same local results. I wanted to wait until we had tests running in Treeherder as the official source of truth for what is passing or failing. Once that happens, I'd be happy to help you get the tests green (or let you take it if you prefer).

Comment 3

[Ting-Yu Chou [:ting] (away)]

(In reply to David Major [:dmajor] from comment #2)
> results. I wanted to wait until we had tests running in Treeherder as the
> official source of truth for what is passing or failing. Once that happens,
> I'd be happy to help you get the tests green (or let you take it if you
> prefer).

I see, I'll make it in Treeherder and definitely will need your help after that. For now, when I run:

  $ ASAN_SYMBOLIZER_PATH=/c/w/tools/clang/x64/bin/llvm-symbolizer.exe ./mach mochitest

I got this error everywhere:

  dir: accessible/tests/browser
  Increasing default timeout to 90 seconds on ASAN
  mozprofile.addons WARNING | Could not install c:\w\fx\mc\obj-asan\_tests\testing\mochitest\extensions\mozscreenshots: [Errno 2] No such file or directory: 'c:\\w\\fx\\mc\\obj-asan\\_tests\\testing\\mochitest\\extensions\\mozscreenshots\\install.rdf'
  =================================================================
  AddressSanitizer: nested bug in the same thread, aborting.

  1 ERROR TEST-UNEXPECTED-FAIL | runtests.py | Certificate integration failed
  Buffered messages finished

At least the tests need to be testable before setting them up in Treeherder, I'll investigate this.

Comment 4

[Ting-Yu Chou [:ting] (away)]

My next plan is to setup a test platform similar to linux64-asan (win64-asan maybe) but is only available on Try.

Comment 5

[sebboh (use needinfo)]

Today I visited https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/ and downloaded and ran firefox-63.0a1.en-US.win64-asan-reporter.installer.exe (24-Jul-2018 11:54).

FYI, during installation, I received the following error in a GUI pop-up:

> Title: maintenanceservice_tmp.exe - System Error
> 
> Body: [red circle with white X icon] The program can't start because clang_rt.asan_dynamic-x86-64.dll is missing from your computer.  Try reinstalling the program to fix this problem.
> 
> Buttons: OK

Neither Windows nor clang are my areas of expertise, so I'm not checking the "Add me to CC list" box on this bug.  If you would like me to do something, just use the `need-info` feature.

I learned about ASan via https://blog.mozilla.org/security/2018/07/19/introducing-the-asan-nightly-project/.  My systems has plenty of RAM so I'm happy to help.

Comment 6

[Christian Holler (:decoder)]

(In reply to dave from comment #5)

I filed bug 1478096 to track this, as this bug here is just a generic tracking bug. Thanks for reporting this and supporting the project :)