362507 - Cancelling All Day check turns Event to zero-duration Event

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[vipers101]

Steps to reproduce:
1. Create an event.
2. Edit the event and check All Day checkbox, and click OK. The event is now on the top row.
3. Edit that event again and uncheck All Day checkbox.

Expected result:
Event becomes zero-duration event. If you click OK, the event becomes a line that you can't double-click. But the event can still be searched.

Reproducible: Always

Comment 1

[vipers101]

(In reply to comment #0)
> Steps to reproduce:
> 1. Create an event.
> 2. Edit the event and check All Day checkbox, and click OK. The event is now on
> the top row.
> 3. Edit that event again and uncheck All Day checkbox.
> 
> Expected result:
> Event becomes zero-duration event. If you click OK, the event becomes a line
> that you can't double-click. But the event can still be searched.
> 
> Reproducible: Always
> 

Sorry, forgot the line

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061201 Calendar/0.4a1

Comment 2

[sjfern]

Followed the STR and was able to reproduce the bug several times (using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061201 Calendar/0.4a1)

As mentioned the event can still be searched but is no longer displayed on the content pane displaying the tasks for a given day.

Rebooted and re-installed Calendar to no avail.

Comment 3

[cmtalbert]

> Expected result:
> Event becomes zero-duration event. If you click OK, the event becomes a line
> that you can't double-click. But the event can still be searched.

I believe this is the Observed Result. 

The expected result would be that when the box is unchecked, the event end time will automatically increment to the default event length. For example, when you uncheck the "all day" checkbox, the "end time" on the event automatically sets to one hour after the begin time.

Comment 4

[Joey Minta]

Attachment: fix end time if equal

Patch does as described.  If the start and end times are equal, we increment the end time by the default amount, according to the user's preferences.

Comment 5

[Matthew (lilmatt) Willis]

Comment on attachment 250782 [details] [diff] [review]
fix end time if equal

This is probably the best way to handle this case.

r=lilmatt

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 250782 [details] [diff] [review]
fix end time if equal

ui-review+r2=mvl

Comment 7

[Joey Minta]

patch checked in.

Comment 8

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20070112 Calendar/0.4a1