Closed Bug 1003262 Opened 10 years ago Closed 10 years ago

stop putting "api" in user-agent field

Categories

(Input Graveyard :: Submission, defect, P3)

Product:
Input Graveyard
Component:
Submission
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

References

Details

(Whiteboard: u=dev c=api p=1 s=input.2014q2) 

The API currently puts "api" in the user-agent field. That's lame.

We should create an "is_api" column or something like that which denotes whether the response was created via the api.

That allows us to capture the user agent if we can.
Making this a P3 for this quarter. This involves to parts:

1. create a new column with a schema migration and a data migration moving everything over

2. add a user-agent field to the api so we can grab it if it's there
Priority: -- → P3
Whiteboard: u=dev c=api p= s=input.2014q2
In a PR: https://github.com/mozilla/fjord/pull/273
Assignee: nobody → willkg
This was a 1 point thing.
Whiteboard: u=dev c=api p= s=input.2014q2 → u=dev c=api p=1 s=input.2014q2
Landed in master: https://github.com/mozilla/fjord/commit/a724957

I'm waiting to push this until later today because of the migrations.
Pushed to prod just now. Waiting to verify this until later.
Verified that old responses were all fixed and that new responses have the right value in the Api field.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.