100802 - toolbar flashes when I delete a mail

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

toolbar flashes when I delete a mail

I think it's because we are updating commands.  I think bienvenu worked on this
once.  I think he saw that when going from 1 selected item to 0 to 1 again would
cause us to update commands.  in theory, we could avoid that work.

bienvenu, did you log a bug on this already?  maybe you found it when fixing the
problem where the delete toolbar button was disabled?

Comment 1

[David :Bienvenu]

sure, it's just the selection goes from 1 to 0 back to 1 again, so we update the
commands for each of those transitions. We may already know in the view that
we're doing a delete, in which case we could perhaps disable the command
updating. I'll look at it in a minute.

Comment 2

[scottputterman]

Do you think this would have any impact on delete message perf and if so how
much do you think it would be?

Comment 3

[David :Bienvenu]

yes, it has an impact, but I don't know how much the impact is. It's a fixed
cost and it's worth investigating. Sorry I haven't got around to this - I forgot
because it wasn't assigned to me.

Comment 4

[David :Bienvenu]

Attachment: proposed fix

Comment 5

[David :Bienvenu]

Can I get some reviews? This fix makes it so we don't update the commands while
the delete is going on, so we don't update commands when there's nothing
selected, and then again when we select a message. So we still do an extra
update, but it doesn't cause any repaints, so it should be faster.

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 55944 [details] [diff] [review]
proposed fix

sr=sspitzer

Comment 7

[Cavin Song]

Comment on attachment 55944 [details] [diff] [review]
proposed fix

r=cavin.

Comment 8

[David :Bienvenu]

fix checked in.

Comment 9

[Sheela Ravindran]

I deleted small to large single messages and there was not tool bar flashing 
while deleting a mail message.  I deleted message from the toolbar.

Verified:
2001-11-15-05 win98, linux, mac os x