101295 - Under bg_BG locale, title are not displayed correctly.

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Takayuki KUSANO]

When I set LANG to bg_BG (or BG_BG.CP1251) on Debian GNU/Linux (sid)
(glibc 2.2.4) platform, contents of <title> element are not correctly
displayed on windows's titlebar. Under this environment, nl_langinfo(CODESET)
returns 'CP1251', but Mozilla currently does not support 'CP1251' as a correct
charset name.

Mozilla seems to work fine after I add 'cp1251=windows-1251' to
'charsetalias.properties' or modify
unixcharset.properties like this:

locale.all.bg_BG=ISO-8859-5
     ->
#locale.all.bg_BG=ISO-8859-5
locale.all.bg_BG=windows-1251

Comment 1

[Roy Yokoyama]

assiging to bstell

Comment 2

[Andreas Becker]

qa -> ylong.

Comment 3

[Frank Tang]

Attachment: propose patch

Comment 4

[Frank Tang]

[e-mail]:
Will my patch fix the problem ?

Comment 5

[Yanko Kaneti]

from what i understand the 0.9.5 branch will be cut friday
is there any reason that this is delayed for 0.9.6?

(i woundt understand if you tolf me this needs an very elaborate review process)

Comment 6

[Takayuki KUSANO]

I applied the patch (nllic.CP1252=windows-1252)
to installed unixcharset.properties 
(/usr/lib/mozilla/res/unixcharset.properties on Debian sid),
but mozilla does not work correctly.

(I checked with http://www.tourinfo.bg/)

I checked the source code of mozilla, and found that
unixcharset.Linux.properties is needed. So I created it from
unixcharset.properties and applied the patch. This time, works fine.

(Mozilla in Debian sid does not contains unixcharset.Linux.properties
default at default. If this is a Debian specific problem,
I'll report it to Debian BTS.)

Comment 7

[Frank Tang]

you probably don't need duplicate the whole file
a single line of 

nllic.CP1251=windows-1251

in the new /usr/lib/mozilla/res/unixcharset.Linux.properties probably is enough

Comment 8

[Takayuki KUSANO]

I've tested with 'nllic.CP1251=windows-1251
' only unixcharset.Linux.properties.
Mozilla 0.9.4, Mozilla 0.9.4+, Galeon (CVS) with Mozilla 0.9.4+ works.

Comment 9

[Frank Tang]

should we add all the mapping from cp1250 to cp1257 ?

reassign back to bstell

Comment 10

[Denis Antrushin]

I have similiar problem with KOI8-R encoding - mozilla prepends every russian
word in title with "%/1   koi8-r" string, see attached screenshot.
My mozilla: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:0.9.5+) Gecko/20010929

Comment 11

[Denis Antrushin]

Attachment: bad title string

Comment 12

[kill this account]

--> ftang

Comment 13

[Frank Tang]

give to shanjian

Comment 14

[Shanjian Li]

Attachment: patch

Comment 15

[Shanjian Li]

frank,
I believe the charset name is generic enough to make it into charset alias list. Because we do not 
have a unix generic nillic property list, alais might be a better place than a platform specific 
property file.  I though about the performance impact. Since alias list has been optimized, there 
should be a gain in performance. (We don't have to load "unixcharset.properties" if it can be 
found in alias list.) 
Please review. 

Comment 16

[Frank Tang]

r=ftang

Comment 17

[Shanjian Li]

brendan, Could you sr? 

Comment 18

[Brendan Eich [:brendan]]

Not right now, unless this is a 0.9.7 bug (in which case, its target milestone
is wrong).  Please advise or fix the TM.

/be

Comment 19

[Brendan Eich [:brendan]]

Could someone also use the patch manager to obsolete the first patch, if it is
in fact obsolete -- and to record ftang's r= on the second patch?  In addition
to retargeting at 0.9.8, I mean (by "also").

/be

Comment 20

[Shanjian Li]

done.

Comment 21

[Brendan Eich [:brendan]]

Comment on attachment 61455 [details] [diff] [review]
patch

sr=[e-mail]

Comment 22

[Shanjian Li]

fix checked in. 

Comment 23

[Yuying Long]

I looked at it on 12-28 trunk build on RH7.1-JA:
I still can not see the page title display correctly by change locale to bg_BG
or bg_BG.CP1251 even I login as Czech or Russian ( I don't have Bulgarian
language option on my mchine).

And I got an error message in terminal window:
Gdk-WARNING ** Missing charsets in FrontSet creation
Gdk-WARNING **   MICROSOFT-CP1251

Not sure if I have to verify it on a localized linux machine or need some
special fonts in my machine.

Comment 24

[Andreas Becker]

Reporter (Takayuki), can you help us in verifying this bug?  Please let us know
if this works for you using the latest build.

Comment 25

[Takayuki KUSANO]

It seems to be fixed.
(I've launched latest build (2002021421) and accessed http://www.tourinfo.bg/ and
compare the title of window with the image in it.)

Comment 26

[Yuying Long]

OK, I'll mark it as verified then.