Closed Bug 102046 Opened 24 years ago Closed 24 years ago

Disable the "Advanced Edit..." when OK button is disabled in property dialogs

Categories

(SeaMonkey :: Composer, defect)

Product:
SeaMonkey
Component:
Composer
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.6

People

(Reporter: TucsonTester2, Assigned: cmanske)

Details

(Whiteboard: EDITORBASE)

Attachments

(1 file)

Fix
2.75 KB, patch
hewitt
: review+
kinmoz
: superreview+
Details | Diff | Splinter Review
Build ID: 20010924 Instead of giving an error and making the user click one more time than they have to, is it possible to have the advanced edit button greyed out instead of clickable? Reproducible: Always Steps to reproduce: 1.Open Composer 2.Click on the image button on the toolbar 3.Click on the advanced edit button Actual Results: Composer gives an error. Expected Results: I would expect that the "Advanced Edit..." button would be greyed out. This makes things a bit simpler for the user.
Confirmed on Win 2k using build 20011003, and Mac OSX using build 20011004.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: The "Advanced Edit..." should be greyed out instead of giving an error when clicked on → [RFE] The "Advanced Edit..." should be greyed out instead of giving an error when clicked on
I disagree. Grayed out buttons don't tell the user what's wrong. Error dialog messages do.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → WONTFIX
reopen bug; we should be consistent... either the OK button should also give this message or Advanced Edit button should be disabled.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
This issue exists in thes dialogs: Insert Table, Image, Link, and Named Anchor. After discussion, we've decided to disable the Advanced Edit button with the same rules for Ok button in those dialogs.
Status: REOPENED → ASSIGNED
Summary: [RFE] The "Advanced Edit..." should be greyed out instead of giving an error when clicked on → [RFE] Disable the "Advanced Edit..." when OK button is disabled in property dialogs
Target Milestone: --- → mozilla0.9.6
-->cmanske
Assignee: syd → cmanske
Severity: enhancement → normal
Status: ASSIGNED → NEW
Summary: [RFE] Disable the "Advanced Edit..." when OK button is disabled in property dialogs → Disable the "Advanced Edit..." when OK button is disabled in property dialogs
Attached patch Fix — — Splinter Review
Status: NEW → ASSIGNED
Keywords: patch, review
Whiteboard: EDITORBASE, FIX IN HAND, need r=,sr=
Attachment #55784 - Flags: superreview+
Whiteboard: EDITORBASE, FIX IN HAND, need r=,sr= → EDITORBASE, FIX IN HAND, need r=
Comment on attachment 55784 [details] [diff] [review] Fix r=hewitt
Attachment #55784 - Flags: review+
checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 24 years ago
Keywords: patch, review
Resolution: --- → FIXED
Whiteboard: EDITORBASE, FIX IN HAND, need r= → EDITORBASE
Verified.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: