Closed Bug 1020531 Opened 10 years ago Closed 10 years ago

All of the strings in the tutorial are left-aligned in RTL locales

Categories

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::First Time Experience
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.1, tracking-b2g:backlog, b2g-v2.1 verified, b2g-v2.2 verified)

Status:
VERIFIED FIXED
Milestone:
2.1 S1 (1aug)
Project Flags:
feature-b2g 2.1
tracking-b2g backlog
Tracking Flags:
Tracking Status
b2g-v2.1 --- verified
b2g-v2.2 --- verified

People

(Reporter: ehsan.akhgari, Assigned: pivanov)

References

Details

(Whiteboard: [systemsfe], [priority] )

Attachments

(1 file)

patch for Gaia/master
46 bytes, text/x-github-pull-request
fcampo
: review+
nefzaoui
: feedback+
Details | Review 
All of the strings on top of the screen in the tutorial section where we show people how to use their phone are left aligned (and probably LTR too, but it's hard to check that.)
feature-b2g: --- → 2.1
Hey Tim,

Gregor mentioned your team was owning this bug. Thanks! :)
Flags: needinfo?(timdream)
No. FTU is not owned by my team.
Flags: needinfo?(timdream)
Blocks: 1015338
blocking-b2g: --- → backlog
Whiteboard: [systemsfe], [priority]
Attached file patch for Gaia/master — 

        Attachment #8450066 -
        Flags: feedback?(nefzaoui.ahmed)
Assignee: nobody → pivanov

    
    

    
  
Comment on attachment 8450066 [details] [review]
patch for Gaia/master

LGTM :)

        Attachment #8450066 -
        Flags: feedback?(nefzaoui.ahmed) → feedback+

        Attachment #8450066 -
        Flags: review?(fernando.campo)

    
    

    
  
Comment on attachment 8450066 [details] [review]
patch for Gaia/master

Good oneliner :)

        Attachment #8450066 -
        Flags: review?(fernando.campo) → review+

    
    

    
  
Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/090891b413cc00cbf98ab2aa1b3b69de79dbcbe1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S1 (1aug)

    
    

    
  
This issue is verified on Flame 2.2 and the Flame 2.1.

Result: On the FTU, all of the strings on top of the screen in the tutorial section are aligned to the right side.

Flame 2.2

Device: Flame 2.2  (319mb)(Kitkat Base)(Shallow Flash)
Build ID: 20141126040207
Gaia: 41b7be7c67167f367c3c4982ff08651d55455373
Gecko: 7bcc6573d204
Version: 36.0a1 (2.2)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Flame 2.1 

Device: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141126001202
Gaia: db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko: 211eae88f119
Version: 34.0 (2.1) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]

          status-b2g-v2.1:
          --- → verified

          status-b2g-v2.2:
          --- → verified
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)

    
    

    
  
Mass Edit: adding the [rtl-meta]
Whiteboard: [systemsfe], [priority] → [rtl-meta]

    
  
Whiteboard: [rtl-meta] → [rtl-meta], [systemsfe], [priority]
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][rtl-impact]
Whiteboard: [rtl-meta], [systemsfe], [priority] → [systemsfe], [priority]
blocking-b2g: backlog → ---

          tracking-b2g:
          --- → backlog

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: