102138 - get REQUIRES failsafe for transformiix

Status: RESOLVED FIXED

(Core :: XSLT, defect, P2)

Description

[Axel Hecht]

I have now seen more than once, that the compile lines doesn't even closely
resemble the REQUIRES variables on unix
It adds requirements that aren't there, and it drops requirements that are
there.
This is, well, let's call it annoying.
See todays comet logs for 
extensions/transformiix/source/xml/parser/nsSyncLoader.cpp
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1001682720.6789.gz&fulltext=1
and
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1001683800.7718.gz&fulltext=1,

++ -o ../source/xml/parser/nsSyncLoader.o -c -DOSTYPE=\"Linux2.4\"
-DOSARCH=\"Linux\" -DOJI  -I../../../dist/include/xpcom
-I../../../dist/include/string -I../../../dist/include/dom
-I../../../dist/include/layout -I../../../dist/include/content
-I../../../dist/include/content_xsl -I../../../dist/include/widget
-I../../../dist/include/necko -I../../../dist/include/transformiix
-I../../../dist/include
-I/builds/tinderbox/SeaMonkey/Linux_2.4.2-2_Depend/mozilla/dist/include/nspr     
-I./../source/xslt -I./../source/base -I./../source/net -I./../source/xml
-I./../source/xml/dom -I./../source/xml/util -I./../source/xml/parser
-I./../source/xml/printer -I./../source/xpath -I./../source/xslt/util
-I./../source/xslt/functions -I/usr/X11R6/include   -fPIC  -DMOZ_ENABLE_JS_DUMP 
-I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall -Wconversion
-Wpointer-arith -Wbad-function-cast -Wcast-align -Woverloaded-virtual -Wsynth
-pedantic -Wno-long-long -pipe -fshort-wchar -pthread -O  -DNDEB!
UG -DTRIMME
D -DMOZ_ENABLE_JS_DUMP  -I/usr/X11R6/include -DMOZILLA_CLIENT -include
../../../config-defs.h -Wp,-MD,.deps/nsSyncLoader.pp
../source/xml/parser/nsSyncLoader.cpp

vs.

c++ -o nsSyncLoader.o -c -DOSTYPE=\"Linux2.4\" -DOSARCH=\"Linux\" -DOJI 
-I../../../../../dist/include/string -I../../../../../dist/include/xpcom
-I../../../../../dist/include/necko -I../../../../../dist/include/dom
-I../../../../../dist/include/layout -I../../../../../dist/include/content
-I../../../../../dist/include/widget -I../../../../../dist/include/js
-I../../../../../dist/include/appshell -I../../../../../dist/include/xpconnect
-I../../../../../dist/include/caps -I../../../../../dist/include/transformiix
-I../../../../../dist/include
-I/builds/tinderbox/SeaMonkey/Linux_2.4.2-2_Depend/mozilla/dist/include/nspr     
-I./../../base -I./../../net -I./../dom -I/usr/X11R6/include   -fPIC 
-DMOZ_ENABLE_JS_DUMP  -I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall
-Wconversion -Wpointer-arith -Wbad-function-cast -Wcast-align
-Woverloaded-virtual -Wsynth -pedantic -Wno-long-long -pipe -fshort-wchar
-pthread -O  -DNDEBUG -DTRIMMED -DMOZ_ENABLE_JS_DUMP  -I/usr/X11R6/include -DM!
OZILLA_CLIE
NT -include ../../../../../config-defs.h -Wp,-MD,.deps/nsSyncLoader.pp
nsSyncLoader.cpp

Axel

Comment 1

[Axel Hecht]

up to the order of string and xpcom, the first requires could be the ones
from extensions/transformiix/source/xslt/Makefile.in.
Only that this is compiled a few dirs after xml.
But blaming parallel make is always a good thing.

Axel

Comment 2

[Axel Hecht]

oh, sorry, it's the REQUIRES line of 
extensions/transformiix/build/Makefile.in. And looking at the log, this seems
to make some odd kind of sense. As a bug in make, of course.

Axel

Comment 3

[Jon Granrose]

blocker since this is turning tinderboxen red.

Comment 4

[Alec Flett]

hrmm.. I've been using the REQUIRES stuff for weeks now, and I haven't had
problems... are you sure this isn't something localized to xslt?

Comment 5

[Peter Van der Beken [:peterv]]

Well, I added all the necesary modules to the requires line and it doesn't
build. I'm told this is related to us not building static libraries per
directory. We will change our build system but that will take time. We've had
this one for a long time now and we didn't change it, it used to work.

Comment 6

[Axel Hecht]

To add to this:
adding REQUIRES to transformiix/build/Makefile.in causes *all* included object
files to be rebuilt, from within the build dir. This is sad, and the right thing
will be to move that scheme. But this is more than a quick fix, and as a backout
poses the exact same problem, I would prefer to have you guys manually clobber,
so the object files get built in the right dirs.

As peter checked in to build/Makefile.in, he triggered all this.

Damn, it's our fault after all.

Workaround:
The only missing require in build is locale, peter, could you verify this?
Just add this to build/Makefile.in and make install in build.

Damn again. We do have to fix this. But this will be next week.

Axel

Comment 7

[Peter Van der Beken [:peterv]]

I added "locale" to the REQUIRES in
mozilla/extensions/transformiix/build/Makefile.in. Our build system needs fixing
to be compatible with the REQUIRES stuff apparently. Lowering severity as this
should fix all the current bustage.

Comment 8

[Heikki Toivonen (remove -bugzilla when emailing directly)]

1.1b just about done, moving forward...

Comment 9

[Peter Van der Beken [:peterv]]

Attachment: Remove some REQUIRES

Comment 10

[Peter Van der Beken [:peterv]]

I checked this in. I think this is now fixed thanks to the fix for bug 103659.