1022420 - Disable NS_NO_VTABLE on clang-cl in order to avoid the compiler warning

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[(no longer active)]

Attachment: Disable NS_NO_VTABLE on clang-cl in order to avoid the compiler warning

Comment 2

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd65c6ee90b7

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bd65c6ee90b7

Comment 4

[Benjamin Smedberg]

What is the compiler warning?

Comment 5

[(no longer active)]

(In reply to comment #4)
> What is the compiler warning?

Something about __declspec(novtable) not implemented.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

This can be backed out now. Clang-cl has grown support for novtable.

Comment 7

[(no longer active)]

I'll back it out.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ba0bf101120

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3ba0bf101120