Closed
Bug 102453
Opened 24 years ago
Closed 24 years ago
nsSpaceManager doesn't need an XPCOM interface
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla0.9.6
People
(Reporter: dbaron, Assigned: dbaron)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
51.07 KB,
patch
|
Details | Diff | Splinter Review | |
|
51.60 KB,
patch
|
jag+mozilla
:
review+
waterson
:
superreview+
|
Details | Diff | Splinter Review |
nsSpaceManager is entirely internal to layout -- it doesn't need an XPCOM
interface (nsISpaceManager). If the interface were removed, we could even use
some inline functions for some of the simple things this does (particularly the
ones I'm going to add for bug 86947).
|
Assignee | |
Comment 1•24 years ago
|
||
|
|
Assignee | |
Comment 2•24 years ago
|
||
|
||
Comment 3•24 years ago
|
||
Comment on attachment 55106 [details] [diff] [review]
cleaned-up patch
sr=waterson
Attachment #55106 -
Flags: superreview+
|
|
||
Comment 4•24 years ago
|
||
+ // Get the bouding rect of the trapezoid
typo alert.
Also, what does "semantic compare" mean?
/be
|
|
Assignee | |
Comment 5•24 years ago
|
||
I have to admit that I haven't even read all the code that I moved from one file
to the other. :-)
|
||
Comment 6•24 years ago
|
||
Comment on attachment 55106 [details] [diff] [review]
cleaned-up patch
r=jag
Attachment #55106 -
Flags: review+
|
|
Assignee | |
Comment 7•24 years ago
|
||
Checked in 2001-10-25 22:05/06 PDT.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•