102502 - javascript strict warnings in profileManager.js

Status: VERIFIED FIXED

(SeaMonkey :: Startup & Profiles, defect)

Description

[Henrik Gemal]

When starting profile manager with quicklaunch on it's possible to see the js 
strict warnings...:

Warning: function RenameProfile does not always return a value
Source File: chrome://communicator/content/profile/profileManager.js
Line: 75, Column: 26
Source Code:
              return false;          

Warning: function RenameProfile does not always return a value
Source File: chrome://communicator/content/profile/profileManager.js
Line: 82, Column: 18
Source Code:
      return false;

Warning: redeclaration of var newName
Source File: chrome://communicator/content/profile/profileManager.js
Line: 93, Column: 12
Source Code:
        var newName = newName.value;

Warning: function RenameProfile does not always return a value
Source File: chrome://communicator/content/profile/profileManager.js
Line: 94, Column: 34
Source Code:
        if (!newName) return false;

Warning: redeclaration of var lString
Source File: chrome://communicator/content/profile/profileManager.js
Line: 102, Column: 16
Source Code:
            var lString = aString + invalidChars[i] + bString;

Warning: function RenameProfile does not always return a value
Source File: chrome://communicator/content/profile/profileManager.js
Line: 104, Column: 24
Source Code:
            return false;

Warning: redeclaration of var lString
Source File: chrome://communicator/content/profile/profileManager.js
Line: 116, Column: 14
Source Code:
          var lString = gProfileManagerBundle.getString("profileExists");

Warning: function RenameProfile does not always return a value
Source File: chrome://communicator/content/profile/profileManager.js
Line: 127
Source Code:
}

Warning: function HandleClickEvent does not always return a value
Source File: chrome://communicator/content/profile/profileManager.js
Line: 310
Source Code:
}

Comment 1

[Boris Zbarsky [:bzbarsky]]

fixed by checkin for bug 162333

Comment 2

[K'Trina Medina]

Verified fixed (see bug 162333)