102579 - Implement IsSeparator() properly in the nsXULOutlinerBuilder

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Jan Varga [:janv]]

The current implementation returns always PR_FALSE.
It should check row for type="http://home.netscape.com/NC-rdf#BookmarkSeparator"

Comment 1

[Jan Varga [:janv]]

Attachment: separator.xul

Comment 2

[Jan Varga [:janv]]

Attachment: proposed fix

Comment 3

[Jan Varga [:janv]]

present for blake :)

Comment 4

[Blake Ross]

Thanks, Jan. This was the last bookmarksliner blocker.

Comment 5

[Jan Varga [:janv]]

Attachment: better fix

Comment 6

[Jan Varga [:janv]]

taking

Comment 7

[Blake Ross]

Jan, checked in your patch for this tonight along with bookmarksliner. Thanks 
again for the fix.

(You forgot the return value in nsXULOutlinerBuilder::Init, though, which 
increased leaks by 3MB and sent us scrambling for the culprit for awhile ;-)

Comment 8

[Jan Varga [:janv]]

uff, I'm sorry, but I recall that was a quick fix.
Anyway I asked waterson for sr= last week, maybe he would catch that.