102583 - XML content sink speedup and cleanup...

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[Johnny Stenback (:jst)]

The namespace related methods in nsXMLContentSink copy too much string data, and
also require the caller to copy strings when there's no need to do that, patch
coming up.

Comment 1

[Johnny Stenback (:jst)]

Attachment: Proposed fix.

Comment 2

[Johnny Stenback (:jst)]

Attachment: Even better fix.

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 51584 [details] [diff] [review]
Even better fix.

>+  if (nameSpaceID == kNameSpaceID_Unknown) {
>+    //    namespace error
>+  }
>+
Need an assertion?

Other than that, r=peterv provided the JST Review Simulacrum r'ed it :P.

Comment 4

[Johnny Stenback (:jst)]

Hmm, that part was not supposed to be in the patch, ignore that piece of the
patch :-) I'll attach a new patch w/o that change. Thanks for the review.

Comment 5

[Johnny Stenback (:jst)]

Attachment: Same as above w/o a change that wasn't supposed to be there.

Comment 6

[Johnny Stenback (:jst)]

Attachment: Fix a typo in the above patch.

Comment 7

[Chris Waterson]

Comment on attachment 53700 [details] [diff] [review]
Fix a typo in the above patch.

sr=waterson

Comment 8

[Johnny Stenback (:jst)]

This was fixed a while back.