102598 - new tabs created with Ctrl-T should give focus to the location bar like Ctrl-N

Status: VERIFIED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[Mike Schuette]

2001093008

Summary says it all.

Comment 1

[Jesse Ruderman]

See also bug 37638, Ctrl+N shouldn't focus location bar in the new window.

Comment 2

[WD]

This would be nice, as the first thing I'm going to do after opening a new tab
is to type in a URL to go to.

Comment 3

[Mike Schuette]

In response to the reference to 37638 -

To make the browser understand the difference between "about:blank"/"" and a
real page (and thus give focus to the appropriate element) would require much
more code, and I believe that this is covered by / could be snowballed into
37638 (or be put into a new bug.)
However, it'd be very simple for a new tab to just give focus to the location
bar for consistency with New Window until someone works up a fix for 37638, and
that's what this bug was filed for.

Comment 4

[Mike Schuette]

Attachment: Proposed patch ... my very first to mozilla, so please don't use sharp objects, I'm a bleeder :)

Comment 5

[Mike Schuette]

My patch satisfies me, the reporter, in that it behaves as I would have expected
a fix for this to ... whether or not the code is viable is a whole different
story :) ... (just copy/pasted the code from Startup to BrowserOpenTab)

Context|Open In New Tab gives focus to the content area, and Accel-T gives focus
to the location bar, just like Accel-N/Open In New Window.

Comment 6

[David Hyatt]

For tabs you don't need all the complicated setTimeout stuff.  You can just set
focus right to the URL bar.

Comment 7

[Mike Schuette]

Attachment: patch v2 (took out the setTimeout stuff)

Comment 8

[Mike Schuette]

Attachment: same as v2 but with better comments

Comment 9

[Håkan Waara]

Comment on attachment 52265 [details]
same as v2 but with better comments

Looks fine to me.

r=hwaara

Comment 10

[David Hyatt]

It's even easier than that.  You literally need only this line.

gURLBar.focus();

Comment 11

[Mike Schuette]

Attachment: hyatt tells me how to write em, I just do what he says

Comment 12

[Mike Schuette]

I'm warning you, no sharp objects ... you'll be sorry ... :)

Comment 13

[Håkan Waara]

Comment on attachment 52270 [details]
hyatt tells me how to write em, I just do what he says

this looks even better ;)

r=hwaara

Comment 14

[Mike Schuette]

adding approval keyword

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

so BrowserOpenTab never gets called in any situation where the user may prefer 
the content area to take focus?

Comment 16

[David Hyatt]

Attachment: Need to do the focus on a timeout.

Comment 17

[David Hyatt]

Fixed.

Comment 18

[R.K.Aa.]

buildt with the patch on linux:
URL-bar in tabs opened with ctrl+t display about:blank and do not have focus.

Comment 19

[R.K.Aa.]

Oops.. This works just fine, one build later. Patch was in the first time, but i
didn't clobber. Guess something didn't build right.

Comment 20

[Petr Kures]

Actually it's not like Ctrl-N now, because when you use Ctrl-N the location bar
not only gets focus, but URL in location bar is selected (so you can start
typing new URL).

Or should I file another bug on this ? 

Comment 21

[Mike Schuette]

pkures:

Yes, if you're seeing that behavior, I'd file a different bug and just reference
this one in a comment.

Also, make sure to report your platform and build, because I can't reproduce
this error on win32.  (The location in the url bar properly gets selected, so
you can type immediately.)

Comment 22

[Jesse Ruderman]

pkures: [e-mail] beat you too it.  Bug 104478 covers the fact that 
Ctrl+T doesn't select the location bar contents when it focuses the location 
bar.

Comment 23

[sairuh (rarely reading bugmail)]

imo, accel+N shouldn't focus the urlbar [referred to in comment 1], unless
about:blank is loaded. since that's the case with accel+T, however, i'll mark
this vrfy'd [tested with 2001.11.28.0x-comm bits on linux rh7.2, mac 10.1.1 and
winnt].