102602 - Accel+w should close a tab in tabbed mode

Status: VERIFIED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[Akkana Peck]

Last week, accel-W closed the current tab; today it's back to closing the whole
window.  We need to have a way of closing the current tab pane, whether it's
accel-W or something else; I have no strong preferences but perhaps someone else
does.

Comment 1

[sairuh (rarely reading bugmail)]

->tabbed browser

Comment 2

[Alex Bishop]

Some people in MozillaZine have suggested accel+F4 (consistent with Windows MDI 
conventions).

Comment 3

[Akkana Peck]

I've also seen suggestions of accel-shift-w -- easy to remember (similar to
accel-w for closing a window) and doesn't have problems with F-keys being bound
to window manager or OS level events, or not being on the keyboard at all.

Comment 4

[David Hyatt]

accel-W has never closed the current tab.  Control+f4 does currently close the
current tab.

I will make Accel+W close the current tab (and the window if you only have one
tab), and make Accel+Shift+W always close the entire window.

Comment 5

[Doron Rosenberg (IBM)]

the accel-w can be done by editing navigator.js's function BrowserClose()

  var browser = getBrowser();
  if (browser.mTabContainer.childNodes.length > 1){
    browser.removeTab(browser.mCurrentTab);
  } else {

not sure if the childNodes.length is the best method

Comment 6

[Mike Schuette]

*** Bug 105543 has been marked as a duplicate of this bug. ***

Comment 7

[Illtud Daniel]

Hi - I submitted this under <a 
href="http://bugzilla.mozilla.org/show_bug.cgi?id=105620">bug 105620></a> - I
did search for reports first, but didn't hit. I'm sorry.

I feel very strongly that ctrl-n & ctrl-w should apply to the <b>current
tab</b> when in tabbed mode - an additional 'shift' (ie ctrl-shift-n to
open) would be my preference for opening & closing whole windows when
in tabbed mode. Ctrl-t should not be 'open new tab' (the issue discussed
in the other bug mentioned above) since that's <i>always</i> been 'get
new mail' (which isn't operational when browsing, but good UI practice
surely demands that you can't have totally different functions with the
same keybinding).

Comment 8

[Jeremy M. Dolan]

Grrr... just lost a big bugzilla comment, trying to close another tab.

Comment 9

[timeless]

Copying comments (because comment referencing has to wait for bugzilla 2.16)
------- Additional Comments From [e-mail] 2001-10-22 20:05 -------

ctrl+shft+n is new blank page to edit, i suppose we could move that to
ctrl+shift+e just for fun and added confusion.

Comment 10

[Christopher Aillon (sabbatical, not receiving bugmail)]

*** Bug 106734 has been marked as a duplicate of this bug. ***

Comment 11

[David Hyatt]

Attachment: Here it is!

Comment 12

[jag (Peter Annema)]

Comment on attachment 55220 [details] [diff] [review]
Here it is!

r=jag

Comment 13

[Brendan Eich [:brendan]]

Who should sr= this patch?  Blake, can you do the deed?

/be

Comment 14

[Jeremy M. Dolan]

Er... isn't this already checked in?

     ^w is closing tabOrWindow
shift^w is closing window

I do like Illtud's suggestion about making ^N do a new tab in tab mode, and
shift^N a new window. More consistant, and there's way too many tab prefs as it
is. Should be one or two, eaither you prefer tabs over windows or you don't.
Having a seperate pref for the toolbar buttons is just silly.

Comment 15

[Josh Steiner]

this is workin for me now, thank god.  about ctrl-shift-n ... that is already
bound to "blank page to edit" ... which seems a little crackrock to me, but
there it is.

Comment 16

[sairuh (rarely reading bugmail)]

yep, right now accel+w closes a tab and accel+shift+w closes the window [when
tabs are present].

Comment 17

[Jeremy M. Dolan]

> ctrl-shift-n ... that is already bound to "blank page to edit"

...and that could move to ctrl-shift-e, which is ALSO more consistant.

Actually, that doesn't even NEED a hotkey like that, it's already got a
component bar icon, a tasks menu entry, and accel+4.

Comment 18

[David Hyatt]

This is checkedi n, yeah.  Oops.  Marking fixed.

Comment 19

[sairuh (rarely reading bugmail)]

actually verifying this time! used these commercial verif bits:

linux [rh6.2] - 2001.11.06.12
winnt - 2001.11.06.12
mac 10.1 - 2001.11.06.08