Closed Bug 102684 Opened 24 years ago Closed 24 years ago

HTML source view should end when new page is open into an unchanged new document

Categories

(SeaMonkey :: Composer, defect)

Product:
SeaMonkey
Component:
Composer
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.6

People

(Reporter: TucsonTester2, Assigned: cmanske)

Details

Attachments

(1 file)

Return to non-HTML Source mode before loading new file into existing window.
486 bytes, patch
Brade
: review+
kinmoz
: superreview+
Details | Diff | Splinter Review
Build ID: 20011001 If you open a document in the html source view of a new composer window you can overwrite the open files information. Reproducible: Always Steps to Reproduce: 1.Open composer 2.Switch to the HTML source view 3.Go to File -> Recent Pages -> choose a recently edited page 4.Type in some text in the body 5.Click on the save button and save the file Actual Results: Saving the file will not prompt you for a title. Instead what has happened is that the file was overwritten. The page did not update it's html source view when the page was opened. If you switch to "Normal" view in step 4 you will see that the page will update to what you opened. This only happens after switching views though. Expected Results: I would expect that after opening a page in the HTML source view that the HTML source of the page would be displayed. I would also expect that making a change and saving it in this view would not overwrite any information.
This happens any way you open a page. You can use the "Recent Pages" or the "Open File" button or menu item and it this bug will still reproduce. Also forgot to add to the first post that this is similar to bug 98768
I think everything described would be fine if the HTML source window would update to reflect the newly open content.
Assignee: syd → cmanske
Summary: Data Loss when opening file in HTML source view, making changes, then saving → HTML source view should update when new page is open
Whiteboard: EDITORBASE
This only happens if you haven't typed anything in HTML source mode. If you have, the new file is opened in its own window. As a convenience, we load files into an existing window only if the page hasn't been touched at all. So the expected behavior for this bug is that it returns to "Normal" editing mode before loading the new page, not try to automatically restart the HTML Source session.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Target Milestone: --- → mozilla0.9.6
Keywords: patch, review
Whiteboard: EDITORBASE → EDITORBASE, FIX IN HAND, need r=,sr=
Summary: HTML source view should update when new page is open → HTML source view should end when new page is open into an unchanged new document
Comment on attachment 53673 [details] [diff] [review] Return to non-HTML Source mode before loading new file into existing window. sr=kin@netscape.com
Attachment #53673 - Flags: superreview+
Whiteboard: EDITORBASE, FIX IN HAND, need r=,sr= → EDITORBASE, FIX IN HAND, need r=
Comment on attachment 53673 [details] [diff] [review] Return to non-HTML Source mode before loading new file into existing window. r=brade
Attachment #53673 - Flags: review+
Keywords: patch, review
Whiteboard: EDITORBASE, FIX IN HAND, need r= → EDITORBASE, FIX IN HAND
checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Whiteboard: EDITORBASE, FIX IN HAND
The problem as originally written is fixed. But now when I open a page from HTML view, it does not open with the HTML. Instead it looks just like normal view, but is still showing "<HTML> Source" view at the bottom. Is this the way we want this to function?
You mean the document content looks like "normal" view, but the "HTML Source" is the selected tab at the bottom? That would be a bug - file separately if that's the case. (Can't test right now - in the middle of a build).
Yes, that is exactly what is happening. New bug 108086. Verifying this one.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: