102762 - Cancel does nothing in find dialog when no search text is provided

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Arnoud Berendsen]

Build: 2001100203 on Win2k

Hitting Cancel in the Find dialog does not close the dialog when there is no
text in the textfield.

Steps to reproduce:
1) Hit CTRL-F
2) Clear the textfield
3) Hit Cancel

Result:
Nothing happens

Expected:
Dialog gets closed.

Once you have typed something in the textfield again, the Cancel button works again

Comment 1

[Basil Fritts]

2001100203 trunk, Windows 98. Seeing the same behavior.

Comment 2

[Andrew Simmonds]

linux/20011003
Seing this exact behaviour.

Comment 3

[Asa Dotzler [:asa]]

(reminder: bugs don't get fixed in Browser-General and definitely not when
assigned to me). 

-->XP Apps

Comment 4

[sairuh (rarely reading bugmail)]

regression, all platforms.

->joe? reassign if you're unable to fix soon. thx!

Comment 5

[sairuh (rarely reading bugmail)]

*** Bug 104106 has been marked as a duplicate of this bug. ***

Comment 6

[sairuh (rarely reading bugmail)]

->hyatt, while joe is away...

Comment 7

[Boris Zbarsky [:bzbarsky]]

*** Bug 104709 has been marked as a duplicate of this bug. ***

Comment 8

[R.K.Aa.]

*** Bug 104751 has been marked as a duplicate of this bug. ***

Comment 9

[Olav Vitters]

*** Bug 104771 has been marked as a duplicate of this bug. ***

Comment 10

[Olav Vitters]

*** Bug 104782 has been marked as a duplicate of this bug. ***

Comment 11

[:deanis74]

I see this also with the File Bookmark dialog.  If you clear out the Location
field, Cancel stops functioning.  Looking at both of these behaviors, this may
be a general bug with dialogs and not specific to Find.  It appears that if the
default button (Find for the Find dialog, OK for the File Bookmark dialog) is
disabled then the Cancel button stops working.

Cancel works in both the Text Zoom and Change Master Password dialogs when OK is
disabled, but both of these are <window>s.  Both findDialog.xul and
addBookmark.xul use <dialog>.  As hinted in the summary of bug 104782, this bug
seems to surface only for <dialog>s.

Comment 12

[Andrew Simmonds]

Attachment: patch to fix

Comment 13

[Andrew Simmonds]

This patch fixes the Find dialog aswell as all the other dialogs such as the
File Bookmark dialog. There just happened to be some code that stopped cancel
being pushed if it the OK button was disabled. I put the cancel window.close()
code outside the disabled OK/Find button checking code.

Comment 14

[timeless]

Comment on attachment 53549 [details] [diff] [review]
patch to fix

>+          if (aDlgType == "cancel") {
>+             window.setTimeout(function() {window.close();}, 1);
>+          }
>+
/*perhaps*/
            else
>+              if (aDlgType == "accept") {
/*\perhaps*/
>           var button = this.getButton("accept");
>           if (!button.disabled) {
>             var noCancel = this._fireButtonEvent(aDlgType);
>   
>             if (noCancel) {
>-              if (aDlgType == "accept" || aDlgType == "cancel") {
>                 // calling window.close() while an oncommand event
>                 // call is on the stack fails to close the window, 
>                 // so we need to do this ugly setTimeout hack

Comment 15

[Andrew Simmonds]

Attachment: better patch accounting for that cancel may have an event assigned and that there may be other buttons other than ok and cancel

Comment 16

[Andriy Palamarchuk]

Also in this situation the dialog can't be dismissed <Esc> key.

Comment 17

[Andrew Simmonds]

The patch fixes it.

Comment 18

[sairuh (rarely reading bugmail)]

0.9.5 is out...could this be r/sr'd for checkin into the trunk? thx!

Comment 19

[Joe Hewitt (gone)]

Lets not remove this line:
-              if (aDlgType == "accept" || aDlgType == "cancel") {

Because otherwise clicking Help will cause the window to close.

Just make the one line change at the top of the patch:
-          var button = this.getButton("accept");
+          var button = this.getButton(aDlgType);

sr=hewitt for that change only

Comment 20

[Andrew Simmonds]

Attachment: final patch

Comment 21

[Joe Hewitt (gone)]

Comment on attachment 53855 [details] [diff] [review]
final patch

sr=hewitt

Comment 22

[David Hyatt]

r=hyatt. --> hewitt

Comment 23

[timeless]

checking in

Comment 24

[timeless]

checked in

Comment 25

[Boris Zbarsky [:bzbarsky]]

*** Bug 105967 has been marked as a duplicate of this bug. ***

Comment 26

[R.K.Aa.]

verifying that clicking cancel button now closes the Find dialog on Linux.
Testing w/current CVS.

Comment 27

[R.K.Aa.]

*** Bug 106395 has been marked as a duplicate of this bug. ***

Comment 28

[Andrew Simmonds]

verifying that this bug is now fixed.

Comment 29

[R.K.Aa.]

*** Bug 106688 has been marked as a duplicate of this bug. ***