Closed Bug 1028122 Opened 10 years ago Closed 10 years ago

Remove public destructors of classes using MFBT RefCounted (or add them to the whitelist)

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Version:
Other Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: bjacob, Unassigned)

References

Details

This is a followup of bug 1027251 for classes using MFBT RefCounted.
Summary: Remove public destructors of classes using MFBT RefCounted → Remove public destructors of classes using MFBT RefCounted (or add them to the whitelist)
Oh, wait a second... we can't do that, as in C++ child classes don't have access to derived classes' private or protected methods, so MFBT RefCounted forces public destructors, unless we always befriend the RefCounted base class, which is in fact the primary reason why we reached the conclusion that RefCounted was a bad idea.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
Yes, this is the reason why trying to get feature parity in RefCounted is a bad idea (because it's impossible) and we should just get rid of it entirely.
You need to log in before you can comment on or make changes to this bug.