1028142 - Remove dangerous public destructor of CSF::VideoControl

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

In bug 1027251 we removed all dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist.

One of them is: CSF::VideoControl

Comment 1

[Anuj Agarwal [:anujagarwal464]]

Attachment: bug1028142.diff

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 8454912 [details] [diff] [review]
bug1028142.diff

Review of attachment 8454912 [details] [diff] [review]:
-----------------------------------------------------------------

If that is that simple, then that's great! Do you have tryserver access, though? I did try to fix myself such trivial cases, so I was sort of expecting that those for which I added HasDangerousPublicDestructor were not so trivial.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Make the destructor of CSF::VideoControl private.

This is just Anuj's patch rebased a tiny bit.

try: https://tbpl.mozilla.org/?tree=Try&rev=daa327c18c40

Comment 4

[Adam Roach [:abr]]

Comment on attachment 8464355 [details] [diff] [review]
Make the destructor of CSF::VideoControl private.

Review of attachment 8464355 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine. Thanks.

Comment 5

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00aaf442d9b9

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/00aaf442d9b9