102831 - if focus is the url bar, ctrl-f4 does not close the topmost tab

Status: VERIFIED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[Josh Steiner]

1. ctrl-t to create a new tab
2. click in the url bar
3. press ctrl-f4 and the tab will not close

Comment 1

[Peter Trudelle]

->andreww, without whom this would fall off our schedule.

Comment 2

[Jesse Ruderman]

*** Bug 110910 has been marked as a duplicate of this bug. ***

Comment 3

[andreww]

note to self - ctrl(cmd) w and t are defined globally in navigator.xul whilst 
ctrl f4 is in the binding. Move that out to exist at same location as T and W

Comment 4

[andreww]

adjusting milestone

Comment 5

[andreww]

Attachment: changes to navigatorOverlay.xul and navigator.dtd

patch ready for review

Comment 6

[Joe Hewitt (gone)]

I would rather that this just be handled automatically by tabbrowser. Perhaps
the Ctrl-F4 keyhandler in tabbrowser should be a capturing handler

Comment 7

[Jesse Ruderman]

Why does Ctrl+W work but not Ctrl+F4?

Comment 8

[Jesse Ruderman]

*** Bug 139846 has been marked as a duplicate of this bug. ***

Comment 9

[Sitsofe Wheeler]

Seeing this on 20020421 Linux. Btw: under unices ctrl-w is already taken for
deleting words when inside text fields so this shortcut will not close a tab
from the location bar.

OS+Platform -> All

Comment 10

[Pete Boyd]

*** Bug 145998 has been marked as a duplicate of this bug. ***

Comment 11

[Kevin Butler]

I filed this as 139846, but it appears to be the same problem, with a slightly
different trigger.  I was requested to add my description with the alternate way
of getting into this state:

If a tab is opened but the URL points to a file that just gets a 'save as'
dialog, the tab opens to 'about:blank'.  If you attempt to close that tab with
ctrl-f4, it won't close.  You can close it by clicking the <X> (close tab) button.

If you just open 'about:blank' in a new tab, you can close it normally.

Reproducible: Always
Steps to Reproduce:
1. Open a page with a downloadable .exe file (e.g., go to
http://download.com.com/3002-2098-911823.html?tag=dir )
2. Right-click on the link (www.microsoft.com for the above)
3. Choose 'open in new tab'
4. Observe new tab opens ("Untitled")
5. When "Save as" dialog appears, just click 'cancel'
6. Observe that the new tab remains open
7. Click on the tab (to bring it to the front if you have tabs opening in the
background)
8. Press Ctrl-F4 to close the tab (tab remains open)
9. Click the <X> button to close the tab (tab closes)

Expected Results:  Ideally, if a new tab (or new window) just results in a file
to save, instead of sticking around with about:blank displayed, the new
tab/window should close automatically...

Second best would be to make ctrl-f4 work correctly.

Additional note:

After getting a tab in this state, if I click to select the tab, then click in
the "content" frame, I can then close the tab with ctrl-f4.

Comment 12

[Jesse Ruderman]

See also bug 114170, ctrl+pgup/pgdn (to switch tabs) doesn't work with focus in
url bar.

Comment 13

[sairuh (rarely reading bugmail)]

nominating...

Comment 14

[Johan Dahlin]

*** Bug 170362 has been marked as a duplicate of this bug. ***

Comment 15

[Samir Gehani]

Nav triage team: nsbeta1-

Comment 16

[Dan Reif]

Still a problem as of build 2003021008 (1.3b).

Dan

Comment 17

[firemotion+mozilla]

*** Bug 232708 has been marked as a duplicate of this bug. ***

Comment 18

[Kevin Brosnan]

*** Bug 251600 has been marked as a duplicate of this bug. ***

Comment 19

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Blake fixed bug 232708 for firefox only - his checkin is here:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/toolkit/content/widgets&command=DIFF_FRAMESET&file=tabbrowser.xml&rev1=1.36.6.12&rev2=1.36.6.13&root=/cvsroot
(I could not find a patch in Bugzilla).  Presumably something similar would
apply to Seamonkey.

I'm cc'ing bz because of the differences between
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpfe/global/resources/content/bindings/tabbox.xml#158
and
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/content/widgets/tabbox.xml#158

Comment 20

[Boris Zbarsky [:bzbarsky]]

Ctho, could you possibly merge the bindings so there are no differences?  May as
well start converting to toolkit, and here is as good a place as any.

Comment 21

[Christian :Biesinger (don't email me, ping me on IRC)]

I should note... tabbox.xml in firefox misses the ability to show a "New Tab" button

Comment 22

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

(In reply to comment #20)
> Ctho, could you possibly merge the bindings so there are no differences?  May as
> well start converting to toolkit, and here is as good a place as any.

That's actually why I'm working on this - I was diffing the various tab files
and found the fixed Firefox bug.

(In reply to comment #21)
> I should note... tabbox.xml in firefox misses the ability to show a "New Tab"
button

Yeah, that's the next thing I'll have to figure out.  After this bug is fixed,
that will be the only difference between the tabbox.xml files.

Comment 23

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Blake, in your checkin for bug 232708, you changed the event listener from
non-capturing to capturing.  Is there a reason for that change?  The checkin is
here:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=AviaryBranchTinderbox&branch=AVIARY_1_0_20040515_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2004-07-26+20%3A00&maxdate=2004-07-26+20%3A25&cvsroot=%2Fcvsroot

The patch seems to work even without a capturing event listener.

Comment 24

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

Firefox works without a capturing event listener... I've attached a patch to
change firefox in bug 282178.

Comment 25

[[e-mail]]

Comment on attachment 175498 [details] [diff] [review]
patch

Patch is malformed. Also the added code in the destructor does not belong in a
loop.

Comment 26

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: fixed patch

Sorry, I don't know what I did to the other patch.

Comment 27

[[e-mail]]

Comment on attachment 175604 [details] [diff] [review]
fixed patch

Although I wonder if Ctrl+F4 would be better served as a <key> in
navigatorOverlay.xul

Comment 28

[timeless]

Comment on attachment 175604 [details] [diff] [review]
fixed patch

please file a bug to remove this from the mac target

Comment 29

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

checked in

Comment 30

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED for me using build 2005-04-05-06 on Windows XP Seamonkey trunk.