102852 - Picker to choose keywords and users

Status: RESOLVED DUPLICATE of bug 80169

(Bugzilla :: User Interface, enhancement)

Description

[Ludovic Dubost]

DESCRIPTION:
 
This patch provides a picker for choosing keywords. Another patch will provide a
user picker.
 
DETAILS:
 
libpicker.js, picker.cgi, picker_search.cgi, picker_searchresult.cgi:
 
database and ldap picker that is used by the keyword picker as well as the user
picker (other bug). This picker is able to be used to search in different
databases as well as ldap in the same installation..
 
keyword_picker.patch:
 
patch inserting the picker code into the edit bug and bug list (for multiple edits)
 
REQUIREMENTS:
 
- Node
 
AUTHOR(S):
 
This patch has been developed by Ludovic Dubost <[e-mail]> for the
bugzilla installation at Netvalue (http://www.netvalue.com).

Comment 1

[Ludovic Dubost]

Attachment: Picker library

Comment 2

[Ludovic Dubost]

Attachment: Picker frame set

Comment 3

[Ludovic Dubost]

Attachment: Picker search form

Comment 4

[Ludovic Dubost]

Attachment: Picker search page

Comment 5

[Ludovic Dubost]

Attachment: Patch for keyword picker

Comment 6

[Myk Melez [:myk] [@mykmelez]]

possible dupe of bug 80169.

Comment 7

[Ludovic Dubost]

Attachment: Picker Search Page v2

Comment 8

[Ludovic Dubost]

I would like to rename attachment "picker search patch v2" to "picker search
page v2".. and mark "picker search page" obsolete..

The update is just to allow search on multiple fields in the Database...

Comment 9

[Dave Miller [:justdave]]

Comment on attachment 51836 [details]
Picker library


This file contains the following copyright notice:

> * last updated	: 971228
> * by Ludovic Dubost - December 1997
> *
> * Copyright Netvalue 2001

with no other licensing info specified.  This basically prevents us from being 
able to use it because there is no permission granted for modifications or 
distribution.

Netvalue would need to re-release this file under Mozilla Public License before 
we can use it.

Comment 10

[Ludovic Dubost]

Attachment: Picker Library v2

Comment 11

[Ludovic Dubost]

I've re-released the picker library using the MPL...
BTW, attachment 51839 [details] and now 51836 should be marked obsolete..

Comment 12

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 13

[John Levon]

*** Bug 114799 has been marked as a duplicate of this bug. ***

Comment 14

[Jouni Heikniemi]

Comment on attachment 51840 [details] [diff] [review]
Patch for keyword picker

[e-mail]: This patch is badly outdated and many of the files need
templatization. In addition to this, it's hard to review half a dozen of
separate files without filenames. 

If you plan on continuing work with this code, please generate a single diff
-uN (against current trunk codebase) about the whole thing so that it's easier
to install the patch and try it out.

Comment 15

[Ludovic Dubost]

Here are the name of the files..

Picker frame set: picker.cgi
Picker search form: picker_search.cgi
Picker Search Page v2: picker_searchresult.cgi
Picker Library v2: libpicker.js
Patch: bug_form.pl buglist.cgi

I understand the patch is pretemplatization but we don't plan to upgrade our
bugzilla to the templatized one soon (because it means reimplementing many of
our changes) so I'm not sure I will be runnning a diff soon..

Anyway thanks for the diff -uN as I didn't find any documentation on how to
generate the patches the right way...

The actual patches to bug_form.pl and buglist.pl are quite short so should be
quite easy to port to the trunk..

Comment 16

[Dave Miller [:justdave]]

The User Interface component now belongs to Gerv.  Reassigning all UNCONFIRMED
and NEW (but not ASSIGNED) bugs currently owned by Myk (the previous component
owner) to Gerv.

Comment 17

[Dave Miller [:justdave]]

Reassigning back to Myk.  That stuff about Gerv taking over the User Interface
component turned out to be short-lived.  Please pardon our confusion, and I'm
very sorry about the spam.

Comment 18

[Ludovic Dubost]

Attachment: Patch against 2.17 head of Oct 2nd

This is a new version of the patch against 2.17. You also need to apply the
patch in Bug 221039 that separates the knob code from the edit template.

The modifications are done to the template but the scripts themselves are not
templatized (they are quite simple and there is not much to customize in terms
of look)..

This patch includes the keyword picker but also the user picker of bug 102942.
The user picker is a little obsolete at least for the assigned/cc field as now
there is user matching.. However I still submit it as it is a different
approach..

Comment 19

[Ludovic Dubost]

*** Bug 102942 has been marked as a duplicate of this bug. ***

Comment 20

[PT]

Where can i look at a "user picker" in action ? Do you have a testing site or 
could you provide a screenshot ?

Comment 21

[Jouni Heikniemi]

Comment on attachment 132530 [details] [diff] [review]
Patch against 2.17 head of Oct 2nd

Slight bitrot, but more importantly, I also think we should have all
user-facing code templatized, no matter how little actual customizability there
may be. You can always add CSS classes and stuff, but more importantly, we have
a reasonably good framework for finding template problems (like XSS), which
doesn't help for print-using CGI code.

Comment 22

[Dave Miller [:justdave]]

enhancements without current patches are being pushed to 2.20

Comment 23

[Dave Miller [:justdave]]

Bugzilla 2.20 feature set is now frozen as of 15 Sept 2004.  Anything flagged
enhancement that hasn't already landed is being pushed out.  If this bug is
otherwise ready to land, we'll handle it on a case-by-case basis, please set the
blocking2.20 flag to '?' if you think it qualifies.

Comment 24

[Frédéric Buclin]

About users, we already have the usemenuforusers parameter for a long time. About keywords, this has been implemented in bug 80169 in Bugzilla 3.2.