102921 - Mozilla crashes when Cache in profile dir points to nonexistent directory

Status: VERIFIED FIXED

(Core :: Networking: Cache, defect, P2)

Description

[Michal 'hramrach' Suchanek]

To reproduce: 
1)Make a Mozilla profile
2)Terminate Mozilla
3)Remove Cache dir from your profile
4)Make Cache a symlink pointing to a nonexistenet location
5)Re-run Mozilla

Result:
crash

Expected:
error report, cache disabling?

Comment 1

[Boris Zbarsky [:bzbarsky]]

I think this goes in the category of "Don't Do That".  :)

Comment 2

[gordon]

Seems like we should at least make this not crash.  Targeting for 0.9.6.

Comment 3

[gordon]

Moving to 0.9.8, when necko will be focusing on stability.

Comment 4

[gordon]

Attachment: disable disk cache if we can't create Cache directory.

We call nsIFile::Exists() to determine if we need to create the Cache
directory.  In the case of a symbolic link to a non-existant ojbect, Exists()
calls access() which returns false.  However, the subsequent Create() fails
because the existence of the link prevents the creation of a new directory.

The crash occured because nsDiskCacheDevice::Init() presumed mCacheDirectory
was valid.  I've added a line to return an error if this isn't true.  The
result is to disable the disk cache if it believes it needs to create a new
cache directory, but can't for some reason.

Comment 5

[Darin Fisher]

Comment on attachment 70240 [details] [diff] [review]
disable disk cache if we can't create Cache directory.

sr=darin

Comment 6

[gordon]

Patch checked in.  Marking FIXED.

Comment 7

[Tom Everingham]

verified:   Linux rh6 2002022708