103061 - Find dialog should persist after finding string

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P1)

Description

[sairuh (rarely reading bugmail)]

spun off bug 102975. in previous builds, as well as in Communicator 4.x, when a 
string is found with the Find in Page dialog, the dialog is not dismissed until 
the user hits the Cancel button or the Escape key.

with the 2001.10.03.0x-trunk comm bits on linux, winNT and mac os 9.x, the Find 
in Page is dismissed when the string is found --even if "wrap around" is 
selected.

1. go to http://mozilla.org
2. bring up the Find in Page dialog [accel+F or select Search > Find in Page 
from the menu].
3. in the textfield enter "mozilla" [without the quotes].
4. [optional] select the "wrap around" option.
5. click the Find button.

result: assuming the string is found [see bug 102975 for details of Find failing 
there], it'll be highlighted in the web page...but then the Find in Page dialog 
goes away.

expected: the Find in Page dialog should persist, until explicitly dismissed by 
clicking Cancel or hitting Esc.

Comment 1

[sairuh (rarely reading bugmail)]

nominating. pls reassign as needed.

Comment 2

[Joe Hewitt (gone)]

Attachment: patch to fix

Comment 3

[Joe Hewitt (gone)]

I'm going away on vacation today, so can somebody else please land this patch
once it is reviewed?

Comment 4

[R.K.Aa.]

*** Bug 103080 has been marked as a duplicate of this bug. ***

Comment 5

[Charles Manske]

Comment on attachment 52018 [details] [diff] [review]
patch to fix

r=cmanske

Comment 6

[kinmoz]

Comment on attachment 52018 [details] [diff] [review]
patch to fix

sr=[e-mail]

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 52018 [details] [diff] [review]
patch to fix

a=asa (on behalf of drivers) for checkin to 0.9.5.

Comment 8

[timeless]

checked in

Comment 9

[Fabian Guisset]

Can anyone explain me why this worked before? What broke it?

Comment 10

[[e-mail]]

Fabian, the new dialogs automatically close when you hit enter,
unless the close request is cancelled.

Comment 11

[sairuh (rarely reading bugmail)]

*** Bug 104117 has been marked as a duplicate of this bug. ***

Comment 12

[sairuh (rarely reading bugmail)]

vrfy fixed:

linux - 2001.11.01.12
winNT - 2001.10.31.03
mac 10.1 - 2001.10.31.13