103450 - Tab centered cropping is bad

Status: VERIFIED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[Andrew Simmonds]

Currently the tabs are all cropped in the center. Although this may have minor
advantages it just screws up the readability of the tab itself. 

Im suggesting for it to be cropped on the right hand side instead. All current
software display things in tabs use right crop. For example the Gnome and
Windows taskbars.

Patch to fix will be attached.

Comment 1

[Andrew Simmonds]

Attachment: Patch to change tabs to right cropping

Comment 2

[Andrew Simmonds]

Assigning to myself.

Comment 3

[Andrew Simmonds]

Assigning to myself.

Comment 4

[Andrew Simmonds]

Another try.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Andrew, how does your page affect pages with Hebrew and Arabic titles?  Does it
crop off the beginning or the end of the title?

Comment 6

[Andrew Simmonds]

According to hyatt's patch in bug 95337 cropping automatically reverses itself
for rtl.

so yes, hebrew/arabic/other rtl will work.

Comment 7

[Jesse Ruderman]

Confirmed on Win98.  With a few exceptions, this makes it very difficult to 
read the tab titles.

Comment 8

[David Hyatt]

Please use crop="end".  crop="right" is deprecated.

Comment 9

[Andrew Simmonds]

Attachment: hyatt's suggested change to end

Comment 10

[David Hyatt]

sr=hyatt

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 52406 [details] [diff] [review]
hyatt's suggested change to end

r=bzbarsky

Comment 12

[Andrew Simmonds]

Patch checked in by bzbarsky.

Bug is fixed.

Comment 13

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2001.11.28.0x-comm bits on linux rh7.2, mac 10.1.1 and winnt.

i have a test case at http://hopey.mcom.com/tests/long-title.html