103685 - Caret disappears after deleting a blockquote w/ paragraph style applied

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[TucsonTester2]

Build ID: 20011004

Deleting a blockquote with a paragraph style applied to the line causes the
cursor to disappear.

Reproducible: Always

Steps to Reproduce:
1.Open Composer
2.Click on the indent button on the toolbar to but the line into a blockquote
3.Click on the paragraph drop-down menu on the toolbar and choose Heading 1
4.Hit backspace

Actual Results:
The cursor will disappear.  If you switch views the cursor will not refresh. 
The only way to make it reappear is to type some text.

Expected Results:
I would expect to be able to see the cursor on the page.

Comment 1

[Syd Logan]

Another cursor fun-o-rama (tm) bug.

Comment 2

[michael wendell]

Confirming on Win 2k using build 2001111303.

Comment 3

[Kevin McCluskey (gone)]

Since its a caret issue, Reassigning to mjudge.

Comment 4

[TucsonTester1]

This is still an issue with the 2001121003 build. 

Comment 5

[TucsonTester1]

Build 2001121803
Also notice that after typing some text to make the cursor appear that the
"Choose a paragraph format" still showed as heading 1 but the text was just
plain body text - if you switched to the HTML view and then back to the Normal
view the "Choose a paragraph format" would show as blockquote.
This behavior looks similar to bug number 112704

Comment 6

[Syd Logan]

Rules problem, not caret. I think we need the following. If the user is deleting
stuff with the delete key or backspace, we ought to (effeciently) check and make
sure that we are never inside a blockquote that has no children. If there are no
children, delete the blockquote and perhaps check again (we might be in nested
blockquotes, should we unwind them all?).

Comment 7

[Joe Francis]

Attachment: difss to nsHTMLEditRules.cpp

hand editted diff (i have a bunch of diffs to this file) so the line numbers
may be off.

Basic idea is that I added a check for collapsed selections inside empty block
to the post-proccessing code.  If so, I put a br at selection if it is legal.

Comment 8

[kinmoz]

Comment on attachment 67700 [details] [diff] [review]
difss to nsHTMLEditRules.cpp

sr=[e-mail]

Comment 9

[kinmoz]

Forgot to ask if you could fix the indention in the code you added. (Some places
have tabs that are throwing the formatting off.)

Comment 10

[Joe Francis]

fix landed on trunk

Comment 11

[michael wendell]

Verified on build 2002020803.