103732 - mail status "replied" not set if mail replied "offline"

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Backend, defect, P3)

Description

[Markus Multrus]

The mail-status "replied" is not set correct, if you reply the mail offline.
Steps to reproduce:
1.) Get new mail
2.) select "Work offline"
3.) reply mail
4.) go online, send mail
The status of the just replied mail stays "read" instead of "replied".
Better: The status should be converted to replied, after the mail is sent
successfully.
Always reproducable with Builds 2001100306, 2001091311

Comment 1

[grylchan]

Confirmed on commercial trunk
2001-10-08-09-trunk NT 4.0
2001-10-08-08-trunk linux 2.2
2001-10-08-08-trunk mac 9.1

Replying to a downloaded mesg while offline results in
the status still being listed as 'read' rather than
'replied' when you go back online.

Replying to a downloaded mesg while online, results
in status being changed to 'replied'.

changing status to new

Comment 2

[David :Bienvenu]

the problem is that the mark replied stuff is handled from
nsMsgComposeSendListener, and there isn't one when we're doing a send later.
I'll try to look at extending the send later code to handle this.

Comment 3

[David :Bienvenu]

When we sent the unsent message, we no longer know that it's a reply to a
particular message. To fix this, we could store the replied flag when the send
later operation happens, and play it back later when going back online, though
we don't really know if the actual send has happened (this seems to be what 4.x
did). Or we could add extra info to the unsent message in the unsent messages
folder to know the uri of the msg being replied to, strip that out of the unsent
message before sending it, and use the info to mark the original message as
replied. The latter approach is more reliable, but a lot more work. 

Comment 4

[David :Bienvenu]

*** Bug 65736 has been marked as a duplicate of this bug. ***

Comment 5

[David :Bienvenu]

*** Bug 126544 has been marked as a duplicate of this bug. ***

Comment 6

[David :Bienvenu]

the same problem happens, for the same reason, when you save a reply as a draft.

Comment 7

[David :Bienvenu]

*** Bug 126544 has been marked as a duplicate of this bug. ***

Comment 8

[grylchan]

*** Bug 184647 has been marked as a duplicate of this bug. ***

Comment 9

[Joe Infla]

*** Bug 149395 has been marked as a duplicate of this bug. ***

Comment 10

[Joe Infla]

*** Bug 120791 has been marked as a duplicate of this bug. ***

Comment 11

[David :Bienvenu]

*** Bug 202126 has been marked as a duplicate of this bug. ***

Comment 12

[:aceman]

The solution (and behaviour) proposed in comment #3 seems logical. But some
people are used to the behaviour in old Communicator 4.x. They want a message to
be marked replied even when the reply was never actually sent. They want it as
an indication that they there was some message derived from it (reply, forward,
etc.). My proposal is: as a temporary (or even permanent) workaround, we could
add some new states of a message, which would indicate this situation - reply to
a message created, but not yet really sent. They can be called 'Reply prepared',
'To be forwarded', or something like that. Would new states broke something or
be too much work? Thanks

Comment 13

[David :Bienvenu]

*** Bug 207132 has been marked as a duplicate of this bug. ***

Comment 14

[David :Bienvenu]

I thought of another way to fix this - store the uri of the message we're
replying to in the database for the unsent messages folder. Then, when we're
sending the message, we can pull the uri out of the database and mark the
original message replied, forwarded, etc.

Comment 15

[David :Bienvenu]

Attachment: proposed fix

this patch implements what I described in my previous comment, and does some
other code cleanup.

Comment 16

[David :Bienvenu]

fix checked in, r/sr=mscott

Comment 17

[:aceman]

Great, if it was tested and it works.

David, could you also implement the second way of marking the messages, while
you are at it? Some users wish that the messages are marked immediately after
the reply is composed, not wait until it is really send. Your implementation
could handle this too. When you write the message URI in the database, at this
point you know that there is a reply prepared. You can mark the message replied
to immediately (as replied). And there can be a pref for switching these 2 modes
of operation. I think there isn't much work involved in this hack. Please, make
this if you have time. Thanks.

Comment 18

[jn]

Does the uri in the database automatically change if its mail is deleted or moved?
If not, we might run into problems, because:
what happens, if the original mail is moved to another folder before the Reply
has been sent?

Comment 19

[David :Bienvenu]

re the comment about making it optionally mark a message replied at message
composition or send later time, that's a low priority for me (which is not to
say that someone else couldn't implement it). Re the question about the message
moving between send later and the actual send, that might not work in some
cases, but that's an edge case that would be very difficult to fix.

Comment 20

[:aceman]

If the message is not found (was moved), it can search for it in all other
folders (of the same account). Just extract the message id from the URI and find
the message. I think not too difficult, maybe slow. Deleted messages are no problem.

Comment 21

[Joe Infla]

David Bienvenu, can the fix from this bug be applied to solve the same problem
for messages saved as drafts (bug 128996)?

Comment 22

[David :Bienvenu]

yes, it might.