103737 - ".." to go up a directory is missing the ftp listing [which is in html]

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P1)

Description

[sairuh (rarely reading bugmail)]

summary sez it all. i see this with a trunk build from 10/4 on winnt.

i need to double-check with more recent trunk bits on all platforms... bbiab
with more info...

Comment 1

[sairuh (rarely reading bugmail)]

stephend sez he doesn't see the ellipses-link on a recent mac os x trunk build.

Comment 2

[sairuh (rarely reading bugmail)]

yep, confirming with 2001.10.08.08-trunk comm bits on linux.

bradley, i nominate this for 0.9.6, but would the bug be in the 0.9.5 branch
perchance?

Comment 3

[Bradley Baetz (:bbaetz)]

Yeah, this would be in 0.9.5. There is no way that I'm going to get to this
before the end of this week.

Its a 3 line fix if I ignore the XUL view...

Comment 4

[Chris Lyon]

Isn't this a dupe of Bug 12707?

Comment 5

[Bradley Baetz (:bbaetz)]

No - this was fixed for html, but I broke it when I merged the back ends for
html vs xul. Now I have to reenable it just for html), but not for gopher, while
doing the Right Thing for file listings on all OSs.

Its not complicated, but I'm not going to get to it this week unless someone
fixes bug 60455 for me.

Patches (to nsIndexedToHTML.cpp, I suspect) welcome.

Comment 6

[Bradley Baetz (:bbaetz)]

OK, here we go. I trashed some of the bogus file : vs / logic while I was at it.
(nsLocalFileMac::GetURL always uses a /)

Despite the docs nsIFile::GetParent saying that it returns null when its the
root, it doesn't (at least on unix) - it just returns the root, so the text
still appears for file:/// in html mode, which is disabled for file urls anyway
ATM. dougt, should I file a bug on that?

darin, dougt: r/sr, please?

Comment 7

[Bradley Baetz (:bbaetz)]

Attachment: patch

Comment 8

[Bradley Baetz (:bbaetz)]

jag told me to s/nsDependentCSubString/SubString/, so I did.

I also replaced the for loop with:

        while(finish != start && *finish != '/')
            --finish;

Comment 9

[Doug Turner (:dougt)]

Comment on attachment 54327 [details] [diff] [review]
patch

make sure that benc runs his regression tests after you land this change.

Comment 10

[Bradley Baetz (:bbaetz)]

Attachment: new patch

Comment 11

[Darin Fisher]

Comment on attachment 54589 [details] [diff] [review]
new patch

sr=darin (looks good)

Comment 12

[Bradley Baetz (:bbaetz)]

Checked in

Comment 13

[sairuh (rarely reading bugmail)]

html directory listings now have a "Parent Directory" link, and ftp listings now
have a "Up to a higher level directory" link. tres cool!

linux - 2001.11.01.12
winNT - 2001.10.31.03
mac 10.1 - 2001.10.31.13