Closed Bug 103864 Opened 23 years ago Closed 19 years ago

optimize NS_OUTPUT_STREAM_BUFFER_SIZE (in nsFileStreams.cpp)

Categories

(Core :: Networking, defect, P3)

Product:
Core
Component:
Networking
Type:
defect

Tracking

()

Status:
VERIFIED INVALID
Milestone:
Future

People

(Reporter: darin.moz, Assigned: darin.moz)

References

Details

(Keywords: perf)

i suspect that the current default of 64k is unnecessarily large, and likely contributes unnecessary runtime bloat, especially on pages that cache many documents on disk. 16k may be more suitable default, since that is the current max buffer size used when reading from the network. ultimately these sizes should probably be made configurable and controllable via preferences.
i'll do some performance measurements using cowtools and ibench soon.
Status: NEW → ASSIGNED
Keywords: perf
Priority: -- → P3
Target Milestone: --- → mozilla0.9.6
Blocks: 95314
under winnt, i dropped NS_OUTPUT_STREAM_BUFFER_SIZE down to 16k and didn't notice any performance difference w/ ibench.
Target Milestone: mozilla0.9.6 → mozilla0.9.7
-> 0.9.9
Target Milestone: mozilla0.9.7 → mozilla0.9.9
-> future, most cache writes will soon be using cache block files, so this bug will become less important. not critical for mozilla 1.0
Target Milestone: mozilla0.9.9 → Future
Is this still valid? NS_OUTPUT_STREAM_BUFFER_SIZE doesn't exist anymore, and nsFileStreams.cpp doesn't allocate any buffers themselves?
yeah, this bug is invalid now.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → INVALID
V.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.