103893 - nickname is not NULL-terminated

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Jamie Nicolson]

This code at pkcs11.c:656, in pk11_handleCertObject, doesn't properly
NULL-terminate the copied nickname string.

cert->nickname = (char *)PORT_ArenaAlloc(cert->arena, PORT_Strlen(label)+1);   
       if(cert->nickname == NULL) {
    return CKR_HOST_MEMORY;
}
PORT_Memcpy(cert->nickname, label, PORT_Strlen(label));

This doesn't cause any problems in the code path I witnessed, but it did cause
some confusion during debugging.

Comment 1

[Wan-Teh Chang]

That whole thing can be replaced by a PORT_ArenaStrdup call:
    cert->nickname = PORT_ArenaStrdup(cert->arena, label);

Could you take care of that?  Do you think this fix should
also be checked in on the NSS_3_3_BRANCH? 

Comment 2

[Jamie Nicolson]

Attachment: proposed patch to pkcs11.c

Comment 3

[Jamie Nicolson]

OK, checked in on the NSS_3_3_BRANCH and the trunk.

/cvsroot/mozilla/security/nss/lib/softoken/pkcs11.c,v  <--  pkcs11.c
new revision: 1.8.2.3; previous revision: 1.8.2.2

/cvsroot/mozilla/security/nss/lib/softoken/pkcs11.c,v  <--  pkcs11.c
new revision: 1.17; previous revision: 1.16

Comment 4

[Robert Relyea]

Looks good.
r=relyea

Comment 5

[Wan-Teh Chang]

Changed target milestone to 3.3.2 because the fix is in
3.3.2.