1038966 - Shmem should use refcounted pointer classes when creating SharedMemory

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Andrew McCreight [:mccr8]]

This is the largest piece of work to prepare for bug 1028148.

Shmem manipulates SharedMemory in a number of places, including in IPDL generated code.  Rather than using nsRefPtr and friends, it uses a harrowing combination of nsAutoPtr and manual AddRefing and Releasing.

These SharedMemory are actually owned by the mShmemMap field of the PFoo{Parent,Child} data structures, as far as I can tell.  That is a Chromium IDMap, which I didn't want to mess with to make the ownership explicit there, so instead there is some usage of take() to explicitly move the ownership over.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: part 1 - AllocShmem and AllocUnsafeShmem do not need to use nsAutoPtr.

I'm going on PTO tomorrow, so I'm not going to bother requesting review, but here are the patches in case anybody is curious.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Rename autoptr methods to refptr in lower.py.

Rename these before changing the definition to reduce the noise in the next patch.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 3 - Shmem should use refcounted pointer classes when creating SharedMemory.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8457433 [details] [diff] [review]
part 3 - Shmem should use refcounted pointer classes when creating SharedMemory.

Review of attachment 8457433 [details] [diff] [review]:
-----------------------------------------------------------------

This all looked great. Thanks!

Comment 5

[Andrew McCreight [:mccr8]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/edf7cf2e8fd7
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/833d3741961c
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/c8cee3a37f9c

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/edf7cf2e8fd7
https://hg.mozilla.org/mozilla-central/rev/833d3741961c
https://hg.mozilla.org/mozilla-central/rev/c8cee3a37f9c