104226 - not playing OS sound for new mail on win98

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

not playing OS sound for new mail on win98

I think I need to use "MailBeep" instead of "Mailbeep", I'll confirm that.

"Mailbeep" works on win2k, I'll check if "MailBeep" does too.

if I need to change it, I'll fix the mac nsSound.cpp and 
nsStatusBarBiffManager.cpp.

Comment 1

[(not reading, please use [e-mail] instead)]

MailBeep works for win2k.

Comment 2

[Simon Fraser [no longer active]]

Maybe we should do case-insensitive compare with "mailbeep" in the Mac code?

Comment 3

[(not reading, please use [e-mail] instead)]

talking with simon, we're going to do this:

use "_moz_mailbeep" in nsStatusBarBiffManager.cpp and in the various 
implementations of nsSound, do the right thing.

for mac, that means using internet config.

for windows, that means playing the system sound "MailBeep".

patch coming soon.

Comment 4

[(not reading, please use [e-mail] instead)]

Attachment: patch, ignore the folder listener stuff.

Comment 5

[Simon Fraser [no longer active]]

Comment on attachment 53147 [details] [diff] [review]
patch, ignore the folder listener stuff.

sr=sfraser

Comment 6

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 53147 [details] [diff] [review]
patch, ignore the folder listener stuff.

r=pink

Comment 7

[(not reading, please use [e-mail] instead)]

fixed

Comment 8

[(not reading, please use [e-mail] instead)]

sheela, do you have access to win2k, win98 and winme?

if so, when you return to the trunk, could you verify by trying all the windows
platforms you can get to?

Comment 9

[(not reading, please use [e-mail] instead)]

re-opening.  today's build is not working on my win98 machine.

Comment 10

[Sheela Ravindran]

Yes, I will check them on all. I have win98 myself.  Ninoschka has winme and
Stephen has win2k. So I will check this when I get to trunk builds.  

Comment 11

[(not reading, please use [e-mail] instead)]

fixing.  I believe it is fixed.

I was just being lame, my sounds were just configured wrong on my win98 box.

I tested, and the default sounds settings do the right thing.

Comment 12

[Sheela Ravindran]

I have verified this on win2k, win98 using 2001-11-15-05 build.  I still have to 
check this on winme. I will get to winme as soon as nbaca is around.  
I hear the moz_mailbeep when I receive the messages. Checked on both imap and 
pop accounts.  

Comment 13

[Sheela Ravindran]

Checked this on today's build on winme-2001-11-15-05