1049379 - Remove dangerous public destructor under mobile/android

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Makoto Kato [:m_kato]]

upcoming gcc 4.9 can use std::is_destructible and NDK r10+ on some platforms can use gcc 4.9...  So we should remove dangerous public destructor.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[Makoto Kato [:m_kato]]

Comment on attachment 8474367 [details] [diff] [review]
fix

This is required for gcc 4.9 (upcoming NDK compiler).

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8474367 [details] [diff] [review]
fix

Review of attachment 8474367 [details] [diff] [review]:
-----------------------------------------------------------------

Brad is on PTO. Patch looks okay though.

Comment 4

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eac6582136b3

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/eac6582136b3