1053364 - Don't warn about nsIProtocolProxyService, nsIProxyAutoConfig, or newProxiedChannel for addons explicitly supporting current application versions

Status: RESOLVED INCOMPLETE

(addons.mozilla.org Graveyard :: Add-on Validation, defect, P4)

Description

[Dave Garrett]

+++ This bug was initially created as a clone of Bug #795168 +++

The addon validator flags usage of nsIProtocolProxyService, nsIProxyAutoConfig, or newProxiedChannel (bug 795168) due to the sync API being removed in favor of async only (bug 769764).

However, the detection isn't particularly smart. I'm still getting notices about this when I upload new versions, and an AMO editor actually mentioned it to me in an email. I think it's long past time to quash these.

What I propose is only flagging these API changes in the validator if the addon's install.rdf does not explicitly set a max supported application version that is current. So, if it has Firefox 31 (current ESR), or equivalent other application version, or later in its max version, then this warning would not apply any longer.

Alternatively, the warning could just be retired altogether, but I don't see a reason not to keep it in there for people updating particularly old addons.

Comment 1

[Wil Clouser [:clouserw]]

Thanks for filing this.  Due to resource constraints we are closing bugs which we won't realistically be able to fix.  If you have a patch that applies to this bug please reopen.

For more info see http://micropipes.com/blog/2014/09/24/the-great-add-on-bug-triage/

Comment 2

[Dave Garrett]

Reopening. This is just routine validator updating. The warning just needs to be updated. At bare minimum, just remove it, as it's not needed anymore.

Comment 3

[Wil Clouser [:clouserw]]

Thanks for the info.  Removing these sounds like a good thing to do